From: Pekka Paalanen <ppaalanen@gmail.com>
To: Leandro Ribeiro <leandro.ribeiro@collabora.com>
Cc: airlied@linux.ie, kernel@collabora.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/1] drm/doc: document drm_mode_get_plane
Date: Fri, 23 Apr 2021 14:11:26 +0300 [thread overview]
Message-ID: <20210423141126.308d4145@eldfell> (raw)
In-Reply-To: <20210422181004.34247-2-leandro.ribeiro@collabora.com>
[-- Attachment #1.1: Type: text/plain, Size: 2081 bytes --]
On Thu, 22 Apr 2021 15:10:04 -0300
Leandro Ribeiro <leandro.ribeiro@collabora.com> wrote:
> Add a small description and document struct fields of
> drm_mode_get_plane.
>
> Signed-off-by: Leandro Ribeiro <leandro.ribeiro@collabora.com>
> ---
> include/uapi/drm/drm_mode.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index a5e76aa06ad5..3e85de928db9 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -312,16 +312,32 @@ struct drm_mode_set_plane {
> __u32 src_w;
> };
>
> +/**
> + * struct drm_mode_get_plane - Get plane metadata.
> + *
> + * Userspace can perform a GETPLANE ioctl to retrieve information about a
> + * plane.
> + */
> struct drm_mode_get_plane {
> + /** @plane_id: Object ID of the plane. */
> __u32 plane_id;
>
> + /** @crtc_id: Object ID of the current CRTC. */
> __u32 crtc_id;
> + /** @fb_id: Object ID of the current fb. */
> __u32 fb_id;
>
> + /** @possible_crtcs: Bitmask of CRTC's compatible with the plane. */
This should probably explain what the bits in the mask correspond to.
As in, which CRTC does bit 0 refer to, and so on.
> __u32 possible_crtcs;
> + /** @gamma_size: Size of the legacy gamma table. */
What are the units? Entries? Bytes?
> __u32 gamma_size;
>
> + /** @count_format_types: Number of formats. */
> __u32 count_format_types;
> + /**
> + * @format_type_ptr: Pointer to ``__u32`` array of formats that are
> + * supported by the plane. These formats do not require modifiers.
I wonder if the "do not require modifiers" is again going too far in
making a difference between this list and IN_FORMATS?
> + */
> __u64 format_type_ptr;
> };
Other than those, looks like a significant improvement to me.
Thanks,
pq
>
> --
> 2.31.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-23 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 18:10 [PATCH v2 0/1] Document drm_mode_get_plane Leandro Ribeiro
2021-04-22 18:10 ` [PATCH v2 1/1] drm/doc: document drm_mode_get_plane Leandro Ribeiro
2021-04-23 11:11 ` Pekka Paalanen [this message]
2021-04-23 21:30 ` Leandro Ribeiro
2021-04-26 7:36 ` Pekka Paalanen
2021-04-26 10:58 ` Simon Ser
2021-04-26 17:30 ` Leandro Ribeiro
2021-04-27 7:40 ` Pekka Paalanen
2021-04-27 9:00 ` Daniel Vetter
2021-04-28 21:42 ` Leandro Ribeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210423141126.308d4145@eldfell \
--to=ppaalanen@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=leandro.ribeiro@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).