Re: linux-next: build warning after merge of the amdgpu tree

Re: linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 624 bytes --]

Hi all,

On Fri, 16 Apr 2021 12:40:44 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
>   312 |  struct pci_dev *rdev;
>       |                  ^~~~
> 
> Introduced by commit
> 
>   9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")

I am still seeing this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the amdgpu tree

[Alex Deucher]

On Wed, Apr 21, 2021 at 2:40 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Fri, 16 Apr 2021 12:40:44 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> > drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
> >   312 |  struct pci_dev *rdev;
> >       |                  ^~~~
> >
> > Introduced by commit
> >
> >   9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
>
> I am still seeing this warning.

I no longer have that patch in my tree.  Was this an old build?

Alex

>
> --
> Cheers,
> Stephen Rothwell
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

Hi Alex,

On Fri, 23 Apr 2021 16:36:50 -0400 Alex Deucher <alexdeucher@gmail.com> wrote:
>
> On Wed, Apr 21, 2021 at 2:40 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Fri, 16 Apr 2021 12:40:44 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > After merging the amdgpu tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced this warning:
> > >
> > > drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> > > drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
> > >   312 |  struct pci_dev *rdev;
> > >       |                  ^~~~
> > >
> > > Introduced by commit
> > >
> > >   9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")  
> >
> > I am still seeing this warning.  
> 
> I no longer have that patch in my tree.  Was this an old build?

I guess my email crossed with the patch removal as I not longer get the
warning. Thanks.

-- 
Cheers,
Stephen Rothwell
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:

drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_dio.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_dio.h:1: warning: no structured comments found

Introduced by commit

  d79833f34bdc ("Documentation/gpu: Add entry for the DIO component")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:

drivers/gpu/drm/amd/display/dc/inc/hw/opp.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/inc/hw/opp.h:1: warning: no structured comments found

Introduced by commit

  0fba33311e63 ("Documentation/gpu: Add entry for OPP in the kernel doc")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

Hi all,

On Tue, 15 Aug 2023 21:07:47 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1: warning: 'product_name' not found
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1: warning: 'product_name' not found
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1: warning: 'serial_number' not found
> 
> Introduced by commit
> 
>   7957ec80ef97 ("drm/amdgpu: Add FRU sysfs nodes only if needed")

The above commit is now in the drm tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi all,

On Wed, 26 Oct 2022 12:14:28 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/gpu/drm/amd/display/dc/dc.h:1289: warning: Function parameter or member 'plane_states' not described in 'dc_validation_set'
> 
> Introduced by commit
> 
>   f6ae69f49fcf ("drm/amd/display: Include surface of unaffected streams")

I am still getting this warning (presumably now from Linus' tree).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:

drivers/gpu/drm/drm_connector.c:2215: warning: Function parameter or member 'supported_colorspaces' not described in 'drm_mode_create_hdmi_colorspace_property'
drivers/gpu/drm/drm_connector.c:2239: warning: Function parameter or member 'supported_colorspaces' not described in 'drm_mode_create_dp_colorspace_property'

Introduced by commit

  4d1be821b795 ("drm/connector: Allow drivers to pass list of supported colorspaces")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (htmldocs)
produced this warning:

drivers/gpu/drm/amd/display/dc/dc.h:900: warning: Function parameter or member 'enable_legacy_fast_update' not described in 'dc_debug_options'

Introduced by commit

  4164998e0a9c ("drm/amd/display: Refactor fast update to use new HWSS build sequence")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 696 bytes --]

Hi all,

On Mon, 22 Mar 2021 17:00:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:405: warning: Function parameter or member 'dmcub_trace_event_en' not described in 'amdgpu_display_manager'
> 
> Introduced by commit
> 
>   4057828a1283 ("drm/amd/display: Add debugfs to control DMUB trace buffer events")

I am still seeing this warning (as of next-20210420).  That is now
commit

  46a83eba276c ("drm/amd/display: Add debugfs to control DMUB trace buffer events")

in the drm tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 1099 bytes --]

Hi all,

On Thu, 11 Mar 2021 22:00:33 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'list' not described in 'dal_allocation'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'bo' not described in 'dal_allocation'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'cpu_ptr' not described in 'dal_allocation'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:143: warning: Function parameter or member 'gpu_addr' not described in 'dal_allocation'
> 
> Introduced by commit
> 
>   1ace37b873c2 ("drm/amdgpu/display: Implement functions to let DC allocate GPU memory")

I am still seeing these warnings (as of next-20210420).  That is now
commit

  0dd795323405 ("drm/amdgpu/display: Implement functions to let DC allocate GPU memory")

in the drm tree.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the amdgpu tree

[Daniel Vetter]

On Thu, Jan 21, 2021 at 4:07 AM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > >
> > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
> > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
> > > >  5380 |  struct amdgpu_display_manager *dm = &adev->dm;
> > > >       |                                 ^~
> > > >
> > > > Caused by commit
> > > >
> > > >   98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
> > >
> > > I am still getting this warning.
> >
> > I now get this warning from the drm tree merge.

Drat, I missed that when merging.

> Bhawan sent out the fix today:
> https://patchwork.freedesktop.org/patch/415092/

Applied directly to drm-next, thanks.
-Daniel

>
> Alex
>
> >
> > --
> > Cheers,
> > Stephen Rothwell
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the amdgpu tree

[Alex Deucher]

On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
> > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
> > >  5380 |  struct amdgpu_display_manager *dm = &adev->dm;
> > >       |                                 ^~
> > >
> > > Caused by commit
> > >
> > >   98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
> >
> > I am still getting this warning.
>
> I now get this warning from the drm tree merge.

Bhawan sent out the fix today:
https://patchwork.freedesktop.org/patch/415092/

Alex

>
> --
> Cheers,
> Stephen Rothwell
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 863 bytes --]

Hi all,

On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > 
> > After merging the amdgpu tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning: unused variable 'dm' [-Wunused-variable]
> >  5380 |  struct amdgpu_display_manager *dm = &adev->dm;
> >       |                                 ^~
> > 
> > Caused by commit
> > 
> >   98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")  
> 
> I am still getting this warning.

I now get this warning from the drm tree merge.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 1226 bytes --]

Hi all,

On Tue, 15 Dec 2020 06:56:08 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 17 Nov 2020 15:45:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_x_start_property' not described in 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_y_start_property' not described in 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_x_end_property' not described in 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_y_end_property' not described in 'amdgpu_display_manager'
> > 
> > Introduced by commit
> > 
> >   c920888c604d ("drm/amd/display: Expose new CRC window property")  
> 
> I am still getting those warnings.  That commit is now in the drm tree.

These warnings are now from Linus' tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 1062 bytes --]

Hi all,

On Tue, 17 Nov 2020 15:45:14 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_x_start_property' not described in 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_y_start_property' not described in 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_x_end_property' not described in 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function parameter or member 'crc_win_y_end_property' not described in 'amdgpu_display_manager'
> 
> Introduced by commit
> 
>   c920888c604d ("drm/amd/display: Expose new CRC window property")

I am still getting those warnings.  That commit is now in the drm tree.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build warning after merge of the amdgpu tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 497 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c: In function 'vcn_v2_5_hw_init':
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:288:5: warning: 'r' may be used uninitialized in this function [-Wmaybe-uninitialized]
  288 |  if (!r)
      |     ^

Introduced by commit

  99bcbf833e6a ("drm/amdgpu: enable VCN0 and VCN1 sriov instances support for Arcturus")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel