From: kernel test robot <lkp@intel.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>, dri-devel@lists.freedesktop.org
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
kbuild-all@lists.01.org, devicetree@vger.kernel.org,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v5 3/4] drm/i915: init panel orientation property
Date: Thu, 29 Apr 2021 10:19:10 +0800 [thread overview]
Message-ID: <202104291042.A5vWUANP-lkp@intel.com> (raw)
In-Reply-To: <20210428170416.1027484-3-hsinyi@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 3185 bytes --]
Hi Hsin-Yi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.12 next-20210428]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hsin-Yi-Wang/gpu-drm-separate-panel-orientation-property-creating-and-value-setting/20210429-010748
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/c44e5201c88aadd48cd7f9b257d6df3e0c9765c7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hsin-Yi-Wang/gpu-drm-separate-panel-orientation-property-creating-and-value-setting/20210429-010748
git checkout c44e5201c88aadd48cd7f9b257d6df3e0c9765c7
# save the attached .config to linux build tree
make W=1 W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/display/icl_dsi.c: In function 'icl_dsi_add_properties':
>> drivers/gpu/drm/i915/display/icl_dsi.c:1906:2: error: too few arguments to function 'drm_connector_attach_scaling_mode_property'
1906 | drm_connector_attach_scaling_mode_property(&connector->base);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/drm/drm_modes.h:33,
from include/drm/drm_crtc.h:40,
from include/drm/drm_atomic_helper.h:31,
from drivers/gpu/drm/i915/display/icl_dsi.c:28:
include/drm/drm_connector.h:1670:5: note: declared here
1670 | int drm_connector_attach_scaling_mode_property(struct drm_connector *connector,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/drm_connector_attach_scaling_mode_property +1906 drivers/gpu/drm/i915/display/icl_dsi.c
1892
1893 static void icl_dsi_add_properties(struct intel_connector *connector)
1894 {
1895 u32 allowed_scalers;
1896
1897 allowed_scalers = BIT(DRM_MODE_SCALE_ASPECT) |
1898 BIT(DRM_MODE_SCALE_FULLSCREEN) |
1899 BIT(DRM_MODE_SCALE_CENTER);
1900
1901 drm_connector_attach_scaling_mode_property(&connector->base,
1902 allowed_scalers);
1903
1904 connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT;
1905
> 1906 drm_connector_attach_scaling_mode_property(&connector->base);
1907 drm_connector_set_panel_orientation_with_quirk(&connector->base,
1908 intel_dsi_get_panel_orientation(connector),
1909 connector->panel.fixed_mode->hdisplay,
1910 connector->panel.fixed_mode->vdisplay);
1911 }
1912
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65095 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-29 2:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 17:04 [PATCH v5 1/4] gpu: drm: separate panel orientation property creating and value setting Hsin-Yi Wang
2021-04-28 17:04 ` [PATCH v5 2/4] drm/mediatek: init panel orientation property Hsin-Yi Wang
2021-04-28 17:04 ` [PATCH v5 3/4] drm/i915: " Hsin-Yi Wang
2021-04-28 20:20 ` Sean Paul
2021-04-29 2:19 ` kernel test robot [this message]
2021-04-28 17:04 ` [PATCH v5 4/4] arm64: dts: mt8183: Add panel rotation Hsin-Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104291042.A5vWUANP-lkp@intel.com \
--to=lkp@intel.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@chromium.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).