From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: "Jacky Liao" <ziyu.liao@amd.com>, "Leo Li" <sunpeng.li@amd.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
"Wenjing Liu" <wenjing.liu@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
"Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>,
"Meenakshikumar Somasundaram"
<meenakshikumar.somasundaram@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
kael_w@yeah.net, "Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] [v2] drm/amd/display: Remove duplicate declaration of dc_state
Date: Thu, 29 Apr 2021 10:30:43 -0400 [thread overview]
Message-ID: <20210429143043.psmabddm74bljtpx@outlook.office365.com> (raw)
In-Reply-To: <20210429123900.25156-1-wanjiabing@vivo.com>
[-- Attachment #1.1: Type: text/plain, Size: 917 bytes --]
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
On 04/29, Wan Jiabing wrote:
> There are two declarations of struct dc_state here.
> Remove the later duplicate more secure.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> Changelog:
> v2:
> - Remove the later duplicate instead of the former.
> ---
> drivers/gpu/drm/amd/display/dc/dc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index 8108b82bac60..6f3c95b5d1a2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -594,7 +594,6 @@ struct dc_bounding_box_overrides {
> int min_dcfclk_mhz;
> };
>
> -struct dc_state;
> struct resource_pool;
> struct dce_hwseq;
> struct gpu_info_soc_bounding_box_v1_0;
> --
> 2.25.1
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-29 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 12:38 [PATCH] [v2] drm/amd/display: Remove duplicate declaration of dc_state Wan Jiabing
2021-04-29 14:30 ` Rodrigo Siqueira [this message]
2021-04-29 14:40 ` Rodrigo Siqueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429143043.psmabddm74bljtpx@outlook.office365.com \
--to=rodrigo.siqueira@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=meenakshikumar.somasundaram@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=qingqing.zhuo@amd.com \
--cc=sunpeng.li@amd.com \
--cc=wanjiabing@vivo.com \
--cc=wenjing.liu@amd.com \
--cc=ziyu.liao@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).