dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Rajeev Nandan <rajeevny@codeaurora.org>
Cc: devicetree@vger.kernel.org, mkrishn@codeaurora.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, dianders@chromium.org,
	seanpaul@chromium.org, abhinavk@codeaurora.org,
	kalyan_t@codeaurora.org, hoegsberg@chromium.org,
	freedreno@lists.freedesktop.org
Subject: Re: [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight
Date: Thu, 29 Apr 2021 13:04:35 -0500	[thread overview]
Message-ID: <20210429180435.GA1385465@robh.at.kernel.org> (raw)
In-Reply-To: <1619416756-3533-2-git-send-email-rajeevny@codeaurora.org>

On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote:
> Add bindings for DisplayPort aux backlight driver.
> 
> Changes in v2:
> - New
> 
> Signed-off-by: Rajeev Nandan <rajeevny@codeaurora.org>
> ---
>  .../bindings/leds/backlight/dp-aux-backlight.yaml  | 49 ++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/backlight/dp-aux-backlight.yaml
> 
> diff --git a/Documentation/devicetree/bindings/leds/backlight/dp-aux-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/dp-aux-backlight.yaml
> new file mode 100644
> index 00000000..0fa8bf0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/dp-aux-backlight.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/dp-aux-backlight.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: DisplayPort aux backlight driver bindings
> +
> +maintainers:
> +  - Rajeev Nandan <rajeevny@codeaurora.org>
> +
> +description:
> +  Backlight driver to control the brightness over DisplayPort aux channel.
> +
> +allOf:
> +  - $ref: common.yaml#
> +
> +properties:
> +  compatible:
> +    const: dp-aux-backlight
> +
> +  ddc-i2c-bus:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      A phandle to the system I2C controller connected to the DDC bus used
> +      for the DisplayPort AUX channel.
> +
> +  enable-gpios:
> +    maxItems: 1
> +    description: GPIO specifier for backlight enable pin.
> +
> +  max-brightness: true
> +
> +required:
> +  - compatible
> +  - ddc-i2c-bus
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    backlight {
> +        compatible = "dp-aux-backlight";
> +        ddc-i2c-bus = <&sn65dsi86_bridge>;
> +        enable-gpios = <&tlmm 12 GPIO_ACTIVE_HIGH>;

So the DDC bus is connected to a backlight and also a panel? This 
binding is not reflecting the h/w, but rather what you want for some 
driver.

There's only one thing here and that's an eDP panel which supports 
backlight control via DP aux channel. You can figure all that out from 
the panel's compatible and/or reading the EDID. 

You might also be interested in this thread:

https://lore.kernel.org/lkml/YIKsDtjcIHGNvW0u@orome.fritz.box/

Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2021-04-29 18:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26  5:59 [v3 0/2] drm: Add support for backlight control of eDP panel on ti-sn65dsi86 bridge Rajeev Nandan
2021-04-26  5:59 ` [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight Rajeev Nandan
2021-04-26 21:04   ` Rob Herring
2021-04-29 18:04   ` Rob Herring [this message]
2021-04-29 21:03     ` Doug Anderson
2021-04-30 15:10       ` rajeevny
2021-04-30 21:38         ` Doug Anderson
2021-05-11 18:11           ` rajeevny
2021-05-11 22:33             ` Laurent Pinchart
2021-05-11 23:17             ` Doug Anderson
2021-05-17 20:21               ` Doug Anderson
2021-05-25  8:03                 ` rajeevny
2021-04-26  5:59 ` [v3 2/2] backlight: Add DisplayPort aux backlight driver Rajeev Nandan
2021-04-26  9:49   ` Jani Nikula
2021-04-26 14:57     ` rajeevny
2021-04-30 18:48     ` Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210429180435.GA1385465@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=abhinavk@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=hoegsberg@chromium.org \
    --cc=kalyan_t@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrishn@codeaurora.org \
    --cc=rajeevny@codeaurora.org \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).