From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A974C433B4 for ; Sun, 2 May 2021 19:51:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C085B6109E for ; Sun, 2 May 2021 19:51:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C085B6109E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cosmicpenguin.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 456B36E546; Sun, 2 May 2021 19:51:33 +0000 (UTC) Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51B216E542 for ; Sun, 2 May 2021 19:51:32 +0000 (UTC) Received: by mail-io1-xd2b.google.com with SMTP id t21so2516612iob.2 for ; Sun, 02 May 2021 12:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cosmicpenguin-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=6wTSvRjZRCi7xWaHiuXeBW7eizhhGCMmkX8gXontjew=; b=yHlSVYqKpW87aQPAUbBHrY2IZxb40wNCc3Amztn6HHkkrwkJOgSL9p/15fPdMBvQHq cRWFvkAhN+yS18R4hU4CCXEgPOw0IajehcefiMLA7+nrsjUmf/MWvNPPi0sewfwJ++Xi kNsEUWVt5wJQ538dsJACfI+oe1rU6es0dQLtD9haznjCBlaKetoT6Wo7+rXVNKgV/TvG LHicek52p/T8LqxlWgwddH0WPHdBo6ekCCTZKSeVIKRArSc7q+OYG+skOIngZC3n1Wjr 7cYbPSPLiJG0nZ/KJweEoOO7mw9wAHR6XarEWo+s5sEKPfiFj+y+u9KEHMNK+Rj6wo13 QIBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=6wTSvRjZRCi7xWaHiuXeBW7eizhhGCMmkX8gXontjew=; b=F2orb0clfBS10992B+Uyo7TNQt639wZKvFiqj1eHLSKjzM8eIB67AGv+3ePwtzxyzF 4iWAzAC8anAA+81WTcvInFV2GMXuX9EW+0+vb+5AhA9R9RNKfCKvzuwMnl/4RAeEFE/V klnt3FAuOrL5tqSy4KM1InoPFXzZCgIN3MwiX4YVNwIyEWEXRvnsbaifc9hKZFgxyYPW ajXOugSihPIamUXgjQMLeOi3X0FWLT9OoDDDBCKDa//3u9MkdotANnP8q42GW+M8l4Ma HLvGW+2G6XZYQiUqfp0E7fEiDjxZmyS9HoovZ+qoIPs3iVxpW9sohq2yedAXBi7NTjku dJGw== X-Gm-Message-State: AOAM531AcLxFX8Vn0a2ad0ZH7QEZI01pLu5DFW0Lhu/PLOAJW8YxrJnw 3ISwRUs8IOOFqt7OGcwSA6GS6g== X-Google-Smtp-Source: ABdhPJxp10aKOLy+kwLqwyA0HIpwpx3dNzwSCoRuQezU/nzXYRn+E/Iz8jRZ77Q++14vSEI3kxyaiA== X-Received: by 2002:a02:cc:: with SMTP id 195mr15669716jaa.73.1619985091752; Sun, 02 May 2021 12:51:31 -0700 (PDT) Received: from cosmicpenguin.net (c-71-237-100-236.hsd1.co.comcast.net. [71.237.100.236]) by smtp.gmail.com with ESMTPSA id w10sm4473063ilm.38.2021.05.02.12.51.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 May 2021 12:51:31 -0700 (PDT) Date: Sun, 2 May 2021 13:51:29 -0600 From: Jordan Crouse To: Jonathan Marek Subject: Re: [PATCH 1/5] drm/msm: remove unnecessary mmap logic for cached BOs Message-ID: <20210502195129.jqayhebdlslpet67@cosmicpenguin.net> Mail-Followup-To: Jonathan Marek , freedreno@lists.freedesktop.org, David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Sean Paul References: <20210423190833.25319-1-jonathan@marek.ca> <20210423190833.25319-2-jonathan@marek.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210423190833.25319-2-jonathan@marek.ca> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Apr 23, 2021 at 03:08:17PM -0400, Jonathan Marek wrote: > No one knows what this is for anymore, so just remove it. Acked-by: Jordan Crouse > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm/msm_gem.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c > index b199942266a2..09abda42d764 100644 > --- a/drivers/gpu/drm/msm/msm_gem.c > +++ b/drivers/gpu/drm/msm/msm_gem.c > @@ -207,21 +207,12 @@ int msm_gem_mmap_obj(struct drm_gem_object *obj, > vma->vm_flags &= ~VM_PFNMAP; > vma->vm_flags |= VM_MIXEDMAP; > > - if (msm_obj->flags & MSM_BO_WC) { > + if (msm_obj->flags & MSM_BO_WC) > vma->vm_page_prot = pgprot_writecombine(vm_get_page_prot(vma->vm_flags)); > - } else if (msm_obj->flags & MSM_BO_UNCACHED) { > + else if (msm_obj->flags & MSM_BO_UNCACHED) > vma->vm_page_prot = pgprot_noncached(vm_get_page_prot(vma->vm_flags)); > - } else { > - /* > - * Shunt off cached objs to shmem file so they have their own > - * address_space (so unmap_mapping_range does what we want, > - * in particular in the case of mmap'd dmabufs) > - */ > - vma->vm_pgoff = 0; > - vma_set_file(vma, obj->filp); > - > + else > vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); > - } > > return 0; > } > -- > 2.26.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel