From: Maxime Ripard <maxime@cerno.tech>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
DRI Development <dri-devel@lists.freedesktop.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] dt-bindings: display: ssd1307fb: Convert to json-schema
Date: Mon, 24 May 2021 13:48:43 +0200 [thread overview]
Message-ID: <20210524114843.ihhgdhup7crskf4j@gilmour> (raw)
In-Reply-To: <CAMuHMdXKaLpLL5Q1FnjHJ5kbs=+9Mm-QHXZp1i3M4zNr7G=e_w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
Hi
On Tue, May 18, 2021 at 04:49:45PM +0200, Geert Uytterhoeven wrote:
> On Tue, May 18, 2021 at 4:33 PM Maxime Ripard <maxime@cerno.tech> wrote:
> > On Tue, May 18, 2021 at 09:51:31AM +0200, Geert Uytterhoeven wrote:
> > > Convert the Solomon SSD1307 Framebuffer Device Tree binding
> > > documentation to json-schema.
> > >
> > > Fix the spelling of the "pwms" property.
> > > Document default values.
> > > Make properties with default values not required.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > ---
> > > I have listed Maxime as the maintainer, as he wrote the original driver
> > > and bindings. Maxime: Please scream if this is inappropriate ;-)
> >
> > Fine by me :)
>
> Thanks!
>
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
>
> > > + solomon,dclk-div:
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + minimum: 1
> > > + maximum: 16
> > > + description:
> > > + Clock divisor. The default value is controller-dependent.
> >
> > I guess we could document the default using an if / else statement?
>
> While clk-div has only two different defaults, dclk-frq has different
> defaults for each of the 4 variants supported.
>
> Do you think it's worthwhile doing that? All upstream DTS files lack
> these properties, thus use the default values.
I'd say it's even more important if everyone relies on it :)
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-05-24 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 7:51 [PATCH] dt-bindings: display: ssd1307fb: Convert to json-schema Geert Uytterhoeven
2021-05-18 14:33 ` Maxime Ripard
2021-05-18 14:49 ` Geert Uytterhoeven
2021-05-24 11:48 ` Maxime Ripard [this message]
2021-05-19 21:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524114843.ihhgdhup7crskf4j@gilmour \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).