From: Jason Ekstrand <jason@jlekstrand.net>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: Jason Ekstrand <jason@jlekstrand.net>
Subject: [PATCH 5/6] RFC: dma-buf: Add an extra fence to dma_resv_get_singleton_unlocked
Date: Mon, 24 May 2021 15:59:53 -0500 [thread overview]
Message-ID: <20210524205954.872814-6-jason@jlekstrand.net> (raw)
In-Reply-To: <20210524205954.872814-1-jason@jlekstrand.net>
For dma-buf sync_file import, we want to get all the fences on a
dma_resv plus one more. We could wrap the fence we get back in an array
fence or we could make dma_resv_get_singleton_unlocked take "one more"
to make this case easier.
Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
---
drivers/dma-buf/dma-buf.c | 2 +-
drivers/dma-buf/dma-resv.c | 23 +++++++++++++++++++++--
include/linux/dma-resv.h | 3 ++-
3 files changed, 24 insertions(+), 4 deletions(-)
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index 86efe71c0db96..f23d939e0e833 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -386,7 +386,7 @@ static long dma_buf_export_sync_file(struct dma_buf *dmabuf,
return fd;
if (arg.flags & DMA_BUF_SYNC_WRITE) {
- fence = dma_resv_get_singleton_unlocked(dmabuf->resv);
+ fence = dma_resv_get_singleton_unlocked(dmabuf->resv, NULL);
if (IS_ERR(fence)) {
ret = PTR_ERR(fence);
goto err_put_fd;
diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
index 312a3a59dac6a..3c0ef8d0f599b 100644
--- a/drivers/dma-buf/dma-resv.c
+++ b/drivers/dma-buf/dma-resv.c
@@ -527,6 +527,7 @@ EXPORT_SYMBOL_GPL(dma_resv_get_fences_unlocked);
/**
* dma_resv_get_singleton_unlocked - get a single fence for the dma_resv object
* @obj: the reservation object
+ * @extra: extra fence to add to the resulting array
* @result: resulting dma_fence
*
* Get a single fence representing all unsignaled fences in the dma_resv object
@@ -536,7 +537,8 @@ EXPORT_SYMBOL_GPL(dma_resv_get_fences_unlocked);
* RETURNS
* Returns -NOMEM if allocations fail, zero otherwise.
*/
-struct dma_fence *dma_resv_get_singleton_unlocked(struct dma_resv *obj)
+struct dma_fence *dma_resv_get_singleton_unlocked(struct dma_resv *obj,
+ struct dma_fence *extra)
{
struct dma_fence *result, **resv_fences, *fence, *chain, **fences;
struct dma_fence_array *array;
@@ -547,7 +549,7 @@ struct dma_fence *dma_resv_get_singleton_unlocked(struct dma_resv *obj)
if (err)
return ERR_PTR(err);
- if (num_resv_fences == 0)
+ if (num_resv_fences == 0 && !extra)
return NULL;
num_fences = 0;
@@ -563,6 +565,16 @@ struct dma_fence *dma_resv_get_singleton_unlocked(struct dma_resv *obj)
}
}
+ if (extra) {
+ dma_fence_deep_dive_for_each(fence, chain, j, extra) {
+ if (dma_fence_is_signaled(fence))
+ continue;
+
+ result = fence;
+ ++num_fences;
+ }
+ }
+
if (num_fences <= 1) {
result = dma_fence_get(result);
goto put_resv_fences;
@@ -583,6 +595,13 @@ struct dma_fence *dma_resv_get_singleton_unlocked(struct dma_resv *obj)
}
}
+ if (extra) {
+ dma_fence_deep_dive_for_each(fence, chain, j, extra) {
+ if (dma_fence_is_signaled(fence))
+ fences[num_fences++] = dma_fence_get(fence);
+ }
+ }
+
if (num_fences <= 1) {
result = num_fences ? fences[0] : NULL;
kfree(fences);
diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h
index c529ccee94bc5..156d989e95ab4 100644
--- a/include/linux/dma-resv.h
+++ b/include/linux/dma-resv.h
@@ -285,7 +285,8 @@ int dma_resv_get_fences_unlocked(struct dma_resv *obj,
int dma_resv_copy_fences(struct dma_resv *dst, struct dma_resv *src);
-struct dma_fence *dma_resv_get_singleton_unlocked(struct dma_resv *obj);
+struct dma_fence *dma_resv_get_singleton_unlocked(struct dma_resv *obj,
+ struct dma_fence *extra);
long dma_resv_wait_timeout_unlocked(struct dma_resv *obj, bool wait_all, bool intr,
unsigned long timeout);
--
2.31.1
next prev parent reply other threads:[~2021-05-24 21:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 20:59 [PATCH 0/6] dma-buf: Add an API for exporting sync files (v10) Jason Ekstrand
2021-05-24 20:59 ` [PATCH 1/6] dma-buf: add dma_fence_array_for_each (v2) Jason Ekstrand
2021-05-24 20:59 ` [PATCH 2/6] dma-buf: Rename dma_resv helpers from _rcu to _unlocked Jason Ekstrand
2021-05-25 14:57 ` Daniel Vetter
2021-05-24 20:59 ` [PATCH 3/6] dma-buf: add dma_resv_get_singleton_unlocked (v4) Jason Ekstrand
2021-05-24 20:59 ` [PATCH 4/6] dma-buf: Add an API for exporting sync files (v9) Jason Ekstrand
2021-05-25 15:08 ` Daniel Vetter
2021-05-24 20:59 ` Jason Ekstrand [this message]
2021-05-25 15:25 ` [Intel-gfx] [PATCH 5/6] RFC: dma-buf: Add an extra fence to dma_resv_get_singleton_unlocked Daniel Vetter
2021-05-24 20:59 ` [PATCH 6/6] RFC: dma-buf: Add an API for importing sync files (v6) Jason Ekstrand
2021-05-25 15:37 ` Daniel Vetter
2021-05-25 19:19 ` Jason Ekstrand
2021-05-25 19:33 ` Daniel Vetter
2021-06-10 21:09 [PATCH 0/6] dma-buf: Add an API for exporting sync files (v12) Jason Ekstrand
2021-06-10 21:09 ` [PATCH 5/6] RFC: dma-buf: Add an extra fence to dma_resv_get_singleton_unlocked Jason Ekstrand
2021-06-11 7:44 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524205954.872814-6-jason@jlekstrand.net \
--to=jason@jlekstrand.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).