From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Christian König" <christian.koenig@amd.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>
Subject: [PATCH v7 08/15] drm/ttm: Use drm_memcpy_from_wc for TTM bo moves
Date: Mon, 31 May 2021 14:19:33 +0200 [thread overview]
Message-ID: <20210531121940.267032-9-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20210531121940.267032-1-thomas.hellstrom@linux.intel.com>
Use fast wc memcpy for reading out of wc memory for TTM bo moves.
Cc: Dave Airlie <airlied@gmail.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Christian König <christian.koenig@amd.com> #v4
--
v4:
- Clarify when we try drm_memcpy_from_wc_dbm (Reported by Matthew Auld)
- Be paranoid about when drm_memcpy_from_wc_dbm may fail (Reported by
Matthew Auld)
v5:
- Rebase on change to drm_memcpy_from_wc (Suggested by Daniel Vetter)
---
drivers/gpu/drm/ttm/ttm_bo_util.c | 19 +++----------------
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
index 6ac7744a1a5c..a46f705ba78b 100644
--- a/drivers/gpu/drm/ttm/ttm_bo_util.c
+++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
@@ -31,6 +31,7 @@
#include <drm/ttm/ttm_bo_driver.h>
#include <drm/ttm/ttm_placement.h>
+#include <drm/drm_cache.h>
#include <drm/drm_vma_manager.h>
#include <linux/dma-buf-map.h>
#include <linux/io.h>
@@ -118,22 +119,8 @@ void ttm_move_memcpy(struct ttm_buffer_object *bo,
dst_ops->map_local(dst_iter, &dst_map, i);
src_ops->map_local(src_iter, &src_map, i);
- if (!src_map.is_iomem && !dst_map.is_iomem) {
- memcpy(dst_map.vaddr, src_map.vaddr, PAGE_SIZE);
- } else if (!src_map.is_iomem) {
- dma_buf_map_memcpy_to(&dst_map, src_map.vaddr,
- PAGE_SIZE);
- } else if (!dst_map.is_iomem) {
- memcpy_fromio(dst_map.vaddr, src_map.vaddr_iomem,
- PAGE_SIZE);
- } else {
- int j;
- u32 __iomem *src = src_map.vaddr_iomem;
- u32 __iomem *dst = dst_map.vaddr_iomem;
-
- for (j = 0; j < (PAGE_SIZE / sizeof(u32)); ++j)
- iowrite32(ioread32(src++), dst++);
- }
+ drm_memcpy_from_wc(&dst_map, &src_map, PAGE_SIZE);
+
if (src_ops->unmap_local)
src_ops->unmap_local(src_iter, &src_map);
if (dst_ops->unmap_local)
--
2.31.1
next prev parent reply other threads:[~2021-05-31 12:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 12:19 [PATCH v7 00/15] Move LMEM (VRAM) management over to TTM Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 01/15] drm/i915: Untangle the vma pages_mutex Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 02/15] drm/i915: Don't free shared locks while shared Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 03/15] drm/i915: Fix i915_sg_page_sizes to record dma segments rather than physical pages Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 04/15] drm/i915/ttm Initialize the ttm device and memory managers Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 05/15] drm/i915/ttm: Embed a ttm buffer object in the i915 gem object Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 06/15] drm/ttm: Add a generic TTM memcpy move for page-based iomem Thomas Hellström
2021-05-31 12:36 ` Christian König
2021-05-31 13:08 ` Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 07/15] drm: Add a prefetching memcpy_from_wc Thomas Hellström
2021-05-31 12:37 ` Christian König
2021-05-31 12:19 ` Thomas Hellström [this message]
2021-05-31 12:19 ` [PATCH v7 09/15] drm/ttm: Document and optimize ttm_bo_pipeline_gutting() Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 10/15] drm/ttm, drm/amdgpu: Allow the driver some control over swapping Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 11/15] drm/i915/ttm: Introduce a TTM i915 gem object backend Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 12/15] drm/i915/lmem: Verify checks for lmem residency Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 13/15] drm/i915: Disable mmap ioctl for gen12+ Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 14/15] drm/vma: Add a driver_private member to vma_node Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 15/15] drm/i915: Use ttm mmap handling for ttm bo's Thomas Hellström
2021-05-31 17:17 ` Thomas Hellström (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531121940.267032-9-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).