From: Zack Rusin <zackr@vmware.com>
To: <dri-devel@lists.freedesktop.org>
Cc: krastevm@vmware.com, sroland@vmware.com
Subject: [PATCH 3/5] drm/vmwgfx: Fix a 64bit regression on svga3
Date: Tue, 15 Jun 2021 14:23:34 -0400 [thread overview]
Message-ID: <20210615182336.995192-3-zackr@vmware.com> (raw)
In-Reply-To: <20210615182336.995192-1-zackr@vmware.com>
Register accesses are always 4bytes, accidently this was changed to
a void pointer whwqich badly breaks 64bit archs when running on top
of svga3.
Fixes: 2cd80dbd3551 ("drm/vmwgfx: Add basic support for SVGA3")
Signed-off-by: Zack Rusin <zackr@vmware.com>
Reviewed-by: Martin Krastev <krastevm@vmware.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
index 0dd5a3e06f5f..356f82c26f59 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
@@ -492,7 +492,7 @@ struct vmw_private {
resource_size_t vram_start;
resource_size_t vram_size;
resource_size_t max_primary_mem;
- void __iomem *rmmio;
+ u32 __iomem *rmmio;
u32 *fifo_mem;
resource_size_t fifo_mem_size;
uint32_t fb_max_width;
--
2.30.2
next prev parent reply other threads:[~2021-06-15 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 18:23 [PATCH 1/5] MAINTAINERS: update vmwgfx info Zack Rusin
2021-06-15 18:23 ` [PATCH 2/5] drm/vmwgfx: Update device headers Zack Rusin
2021-06-15 18:23 ` Zack Rusin [this message]
2021-06-15 18:23 ` [PATCH 4/5] drm/vmwgfx: Fix a bad merge in otable batch takedown Zack Rusin
2021-06-15 18:23 ` [PATCH 5/5] drm/vmwgfx: Fix build issues in mksGuestStats discovered by the kernel test robot Zack Rusin
2021-06-15 18:24 ` [PATCH 1/5] MAINTAINERS: update vmwgfx info Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615182336.995192-3-zackr@vmware.com \
--to=zackr@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=krastevm@vmware.com \
--cc=sroland@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).