From: Chunyou Tang <tangchunyou@163.com>
To: Steven Price <steven.price@arm.com>
Cc: tomeu.vizoso@collabora.com, airlied@linux.ie,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
alyssa.rosenzweig@collabora.com,
ChunyouTang <tangchunyou@icubecorp.cn>
Subject: Re: [PATCH v2] drm/panfrost:report the full raw fault information instead
Date: Sat, 19 Jun 2021 11:18:52 +0800 [thread overview]
Message-ID: <20210619111852.00003e52@163.com> (raw)
In-Reply-To: <2dcbb36a-b550-4c9d-cff8-73ca4b5abb11@arm.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=GB18030, Size: 2484 bytes --]
Hi Steve,
1,Now I know how to write the subject
2,the low 8 bits is the exception type in spec.
and you can see prnfrost_exception_name()
switch (exception_code) {
/* Non-Fault Status code */
case 0x00: return "NOT_STARTED/IDLE/OK";
case 0x01: return "DONE";
case 0x02: return "INTERRUPTED";
case 0x03: return "STOPPED";
case 0x04: return "TERMINATED";
case 0x08: return "ACTIVE";
........
........
case 0xD8: return "ACCESS_FLAG";
case 0xD9 ... 0xDF: return "ACCESS_FLAG";
case 0xE0 ... 0xE7: return "ADDRESS_SIZE_FAULT";
case 0xE8 ... 0xEF: return "MEMORY_ATTRIBUTES_FAULT";
}
return "UNKNOWN";
}
the exception_code in case is only 8 bits,so if fault_status
in panfrost_gpu_irq_handler() don't & 0xFF,it can't get correct
exception reason,it will be always UNKNOWN.
ÓÚ Fri, 18 Jun 2021 13:43:24 +0100
Steven Price <steven.price@arm.com> дµÀ:
> On 17/06/2021 07:20, ChunyouTang wrote:
> > From: ChunyouTang <tangchunyou@icubecorp.cn>
> >
> > of the low 8 bits.
>
> Please don't split the subject like this. The first line of the commit
> should be a (very short) summary of the patch. Then a blank line and
> then a longer description of what the purpose of the patch is and why
> it's needed.
>
> Also you previously had this as part of a series (the first part
> adding the "& 0xFF" in the panfrost_exception_name() call). I'm not
> sure we need two patches for the single line, but as it stands this
> patch doesn't apply.
>
> Also I'm still not receiving any emails from you directly (only via
> the list), so it's possible I might have missed something you sent.
>
> Steve
>
> >
> > Signed-off-by: ChunyouTang <tangchunyou@icubecorp.cn>
> > ---
> > drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> > b/drivers/gpu/drm/panfrost/panfrost_gpu.c index
> > 1fffb6a0b24f..d2d287bbf4e7 100644 ---
> > a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++
> > b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -33,7 +33,7 @@ static
> > irqreturn_t panfrost_gpu_irq_handler(int irq, void *data) address
> > |= gpu_read(pfdev, GPU_FAULT_ADDRESS_LO);
> > dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at
> > 0x%016llx\n",
> > - fault_status & 0xFF,
> > panfrost_exception_name(pfdev, fault_status & 0xFF),
> > + fault_status,
> > panfrost_exception_name(pfdev, fault_status & 0xFF), address);
> >
> > if (state & GPU_IRQ_MULTIPLE_FAULT)
> >
next prev parent reply other threads:[~2021-06-19 3:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 6:20 [PATCH v2] drm/panfrost:report the full raw fault information instead ChunyouTang
2021-06-18 12:43 ` Steven Price
2021-06-19 3:18 ` Chunyou Tang [this message]
2021-06-21 10:45 ` Steven Price
2021-06-22 1:40 ` Chunyou Tang
2021-06-24 13:22 ` Steven Price
2021-06-25 9:49 ` Chunyou Tang
2021-06-28 10:48 ` Steven Price
2021-06-28 14:17 ` Robin Murphy
2021-06-29 3:08 ` Chunyou Tang
2021-06-29 3:04 ` Chunyou Tang
2021-07-01 10:15 ` Steven Price
2021-07-02 1:40 ` Chunyou Tang
2021-07-05 13:50 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210619111852.00003e52@163.com \
--to=tangchunyou@163.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=tangchunyou@icubecorp.cn \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).