From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE30C49EA3 for ; Mon, 28 Jun 2021 10:12:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28E3F6198A for ; Mon, 28 Jun 2021 10:12:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28E3F6198A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94BA26E416; Mon, 28 Jun 2021 10:12:12 +0000 (UTC) Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com [64.147.123.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 380476E416 for ; Mon, 28 Jun 2021 10:12:11 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id D1C692B00828; Mon, 28 Jun 2021 06:12:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 28 Jun 2021 06:12:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=G1ta7c/5/ThX06wXTeoCB5eCgJv sZJNMAJ9Re7t/XCY=; b=zqK0dOCuCE1noPGpc5CJksQS/smvQGb8Jolv2knBnCE ZlMy8mWmE7m0uknVyNTvOVsTxSbsGGCm9cn2b1rk/olrODnaczcN+T6bT766957N fDwTL8yWcU1NZb/9ayjpe9XI4Zatz7AZUyrLAvEmULb2hUgc+xiO941tXHi1x2JB jskcKAK7RLx3hNUUE4tos9TSCFKgftS/fFJw8TbARbRSMqqDvuhp0Pd83nwvK/BS i7FB697n6KHVXTlFCJ4YdSSg1k57217XtZtEk4JaqloWzVs/e1H2Vu0VLc8xjsKY PD2lRyxW5Nnny+5BN8JfXK0WrBHgJmXmPCj1bCZ7MfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=G1ta7c /5/ThX06wXTeoCB5eCgJvsZJNMAJ9Re7t/XCY=; b=WfbrO0P+LWj1h60MSG1mJM 1C7/kdqiLuWZRDHHGZZrg+SXS2ZUOg0zjb8RhUgnNt0dlG3OwVUOwdcXLTakQ/JM 4bKW3bbrnk96s1Z3wBUcfyt60jq1bpN96GNfXJINW10OcJVWYxsLknxEKDGr35xl FRQhSyEnslD5D2qTHZvyuMXarn0NvzO+lj2W+QPblPcp4GMmgmJaX4toLt60e6eK Mc+wiM2hW/a90BPLw0TA8EiHXMhbnOIpU1oyKJ37/kbn/DYyipbBNeyZuz8LmNPC ngM4lQjLUYbBxYHx7BPUxG/0oIYA8Jjac4EOy4JO15WlW8ie8InSTdXts0TO4qPg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeehgedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Jun 2021 06:12:07 -0400 (EDT) Date: Mon, 28 Jun 2021 12:12:05 +0200 From: Maxime Ripard To: Laurent Pinchart Subject: Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe Message-ID: <20210628101205.bul2iwwljxtd24tb@gilmour> References: <20210203091306.140518-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pxsrq5bk7iavnx3y" Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Jonathan Liu , Neil Armstrong , Sam Ravnborg , Jonas Karlman , Sandy Huang , dri-devel , Philippe Cornu , Yannick Fertre , Andrzej Hajda , Jagan Teki , Benjamin Gaignard , Vincent Abriou , linux-amarula , linux-kernel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --pxsrq5bk7iavnx3y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Jun 24, 2021 at 03:51:05PM +0300, Laurent Pinchart wrote: > CC'ing Maxime Ripard. >=20 > Maxime, is this similar to the issue we've recently discussed with the > VC4 DSI encoder ? >=20 > On Thu, Jun 24, 2021 at 10:39:48PM +1000, Jonathan Liu wrote: > > On Thu, 24 Jun 2021 at 22:34, Jagan Teki wrote: > > > On Fri, Jun 18, 2021 at 6:40 PM Jonathan Liu wrote: > > > > On Wed, 3 Feb 2021 at 09:13, Jagan Teki wrote: > > > > > @@ -1167,6 +1151,20 @@ __dw_mipi_dsi_probe(struct platform_device= *pdev, > > > > > dw_mipi_dsi_debugfs_init(dsi); > > > > > pm_runtime_enable(dev); > > > > > > > > > > + ret =3D drm_of_find_panel_or_bridge(dev->of_node, 1, 0, > > > > > + &panel, &bridge); > > > > > + if (ret) > > > > > + return ERR_PTR(ret); > > > > > > > > On RK3399 if the error is EPROBE_DEFER, __dw_mipi_dsi_probe can be > > > > called again and result in the following errors: > > > > [ 0.717589] debugfs: Directory 'ff960000.mipi' with parent '/' a= lready present! > > > > [ 0.717601] dw-mipi-dsi-rockchip ff960000.mipi: failed to create= debugfs root > > > > [ 0.717606] dw-mipi-dsi-rockchip ff960000.mipi: Unbalanced pm_ru= ntime_enable! > > > > > > Is this when you test bridge on rk3399 or panel? > >=20 > > MIPI-DSI to LVDS bridge. It looks more like a driver that doesn't free its resources properly on EPR= OBE_DEFER? Maxime --pxsrq5bk7iavnx3y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYNmgdQAKCRDj7w1vZxhR xR8DAP94cJXuHL0Y5IP7BYZbO+0AfSWavVR1bJBD81CtyTet5AEAzxOwqJgZ0od3 0W8wv1CYlqMx3P/bxlmTi9qwOAuJIwU= =kLbL -----END PGP SIGNATURE----- --pxsrq5bk7iavnx3y--