From: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
To: dri-devel@lists.freedesktop.org, anitha.chrisanthus@intel.com,
edmund.j.dea@intel.com
Subject: [PATCH 09/14] drm/kmb : W/A for planar formats
Date: Tue, 27 Jul 2021 17:31:21 -0700 [thread overview]
Message-ID: <20210728003126.1425028-9-anitha.chrisanthus@intel.com> (raw)
In-Reply-To: <20210728003126.1425028-1-anitha.chrisanthus@intel.com>
This is a work around for fully planar formats, where color corruption
was observed for formats like YU12, YU16 etc. Set the DMA Vstride and
Line width for U and V planes to the same as the Y plane and not the
actual pitch. For decoded video frames, continue to use the info from
metadata.
Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display")
Signed-off-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
---
drivers/gpu/drm/kmb/kmb_plane.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c
index dacec5c4266f..4523af949ea1 100644
--- a/drivers/gpu/drm/kmb/kmb_plane.c
+++ b/drivers/gpu/drm/kmb/kmb_plane.c
@@ -333,6 +333,7 @@ static void kmb_plane_atomic_update(struct drm_plane *plane,
struct disp_cfg *init_disp_cfg;
struct viv_vidmem_metadata *md = NULL;
struct drm_gem_object *gem_obj;
+ unsigned int cb_stride, cr_stride;
if (!plane || !new_plane_state || !old_plane_state)
return;
@@ -397,8 +398,10 @@ static void kmb_plane_atomic_update(struct drm_plane *plane,
val |= get_bits_per_pixel(fb->format);
/* Program Cb/Cr for planar formats */
if (num_planes > 1) {
- kmb_write_lcd(kmb, LCD_LAYERn_DMA_CB_LINE_VSTRIDE(plane_id),
- fb->pitches[1]);
+ cb_stride = md ? fb->pitches[1] : width * fb->format->cpp[0];
+ kmb_write_lcd(kmb,
+ LCD_LAYERn_DMA_CB_LINE_VSTRIDE(plane_id),
+ cb_stride);
kmb_write_lcd(kmb, LCD_LAYERn_DMA_CB_LINE_WIDTH(plane_id),
(width * fb->format->cpp[0]));
@@ -419,9 +422,11 @@ static void kmb_plane_atomic_update(struct drm_plane *plane,
addr[U_PLANE]);
if (num_planes == 3) {
+ cr_stride = md ? fb->pitches[2] :
+ width * fb->format->cpp[0];
kmb_write_lcd(kmb,
LCD_LAYERn_DMA_CR_LINE_VSTRIDE(plane_id),
- fb->pitches[2]);
+ cr_stride);
kmb_write_lcd(kmb,
LCD_LAYERn_DMA_CR_LINE_WIDTH(plane_id),
--
2.25.1
next prev parent reply other threads:[~2021-07-28 0:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 0:31 [PATCH 01/14] drm/kmb: Enable LCD DMA for low TVDDCV Anitha Chrisanthus
2021-07-28 0:31 ` [PATCH 02/14] drm/kmb: Define driver date and major/minor version Anitha Chrisanthus
2021-07-28 7:06 ` Sam Ravnborg
2021-08-04 18:13 ` Thomas Zimmermann
2021-08-05 23:53 ` Chrisanthus, Anitha
2021-07-28 0:31 ` [PATCH 03/14] drm/kmb: Work around for higher system clock Anitha Chrisanthus
2021-07-28 0:31 ` [PATCH 04/14] drm/kmb : W/A for 256B cache alignment for video Anitha Chrisanthus
2021-07-28 7:16 ` Sam Ravnborg
2021-07-28 22:54 ` Chrisanthus, Anitha
2021-07-28 0:31 ` [PATCH 05/14] drm/kmb: Limit supported mode to 1080p Anitha Chrisanthus
2021-07-28 0:31 ` [PATCH 06/14] drm/kmb: Remove clearing DPHY regs Anitha Chrisanthus
2021-07-28 0:31 ` [PATCH 07/14] drm/kmb: Disable change of plane parameters Anitha Chrisanthus
2021-07-28 0:31 ` [PATCH 08/14] drm/kmb: Corrected typo in handle_lcd_irq Anitha Chrisanthus
2021-07-28 0:31 ` Anitha Chrisanthus [this message]
2021-07-28 22:48 ` [PATCH 09/14] drm/kmb : W/A for planar formats Chrisanthus, Anitha
2021-07-28 0:31 ` [PATCH 10/14] drm/kmb: Enable ADV bridge after modeset Anitha Chrisanthus
2021-07-28 7:22 ` Sam Ravnborg
2021-07-28 0:31 ` [PATCH 11/14] drm/kmb: Prune display modes with CRTC vfp < 4 Anitha Chrisanthus
2021-07-28 0:31 ` [PATCH 12/14] drm/kmb: Fix possible oops in error handling Anitha Chrisanthus
2021-07-28 7:27 ` Sam Ravnborg
2021-07-28 23:23 ` Chrisanthus, Anitha
2021-07-28 7:46 ` Dan Carpenter
2021-07-28 0:31 ` [PATCH 13/14] drm/kmb: Enable alpha blended second plane Anitha Chrisanthus
2021-07-28 7:29 ` Sam Ravnborg
2021-08-02 20:44 ` Chrisanthus, Anitha
2021-08-03 5:10 ` Sam Ravnborg
2021-09-08 17:50 ` Thomas Zimmermann
2021-09-08 19:31 ` Sam Ravnborg
2021-09-09 17:46 ` Thomas Zimmermann
2021-07-28 0:31 ` [PATCH 14/14] drm/kmb: Enable support for fbcon (framebuffer console) Anitha Chrisanthus
2021-07-28 7:31 ` Sam Ravnborg
2021-07-28 23:03 ` Chrisanthus, Anitha
2021-07-28 7:04 ` [PATCH 01/14] drm/kmb: Enable LCD DMA for low TVDDCV Sam Ravnborg
2021-07-29 18:48 ` Chrisanthus, Anitha
2021-07-29 19:00 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728003126.1425028-9-anitha.chrisanthus@intel.com \
--to=anitha.chrisanthus@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).