From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A925C433F5 for ; Mon, 20 Sep 2021 22:53:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03F1B611ED for ; Mon, 20 Sep 2021 22:53:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 03F1B611ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AADA46E89D; Mon, 20 Sep 2021 22:53:34 +0000 (UTC) Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 05D486E89C; Mon, 20 Sep 2021 22:53:33 +0000 (UTC) Received: by mail-pg1-x52c.google.com with SMTP id k24so18864396pgh.8; Mon, 20 Sep 2021 15:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z7Kd/fx639sfsLQE+1CpU+ldwaQco2odWCA1BPkcvGw=; b=Ud2vEMCB11Hm5xIjp7frwtre74H8/FnkW4cydkGPAikdhbQBRzGPpzxK6mFY7Iv9dx 89vz5xyLVwFeVrk+rHH21dtigCeYMgzt2HeZlSzv1LL0yGddlrwU9DuWEHap0AwFOp4Y v/YlnLqE0cual8hL2n67Y/vA7KrQLsy4s1CkZ8+6V0q/Nqs3hkPfrE6+zj5xKA3doke+ FltHEs033zpgbCtAbr3KrSTo6sVLxeR63az3iqyta1xeVzYDV3LdoWu7aE5BWLD5qDDK e5LQrrDQUNGH4AMekiLqyULcCMkckO9V7m4fsiSKdDQple8vf/KAUId4rcKy3q0q9Vpj /4VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z7Kd/fx639sfsLQE+1CpU+ldwaQco2odWCA1BPkcvGw=; b=RTYcRBIa/DG6GO55OFFHo+VZSOG0MDkqKdyk8ibz1aWVUSo+yq3te+6F9I31PfBaVH NzGtKpZj4yyJ/aLdUkwAf0q65bM5o/i8+b4TQhsasPQQC15LtRIAw6+vjvnLTfp9EUHP g1DGZZhij7wJqvCrG/Rk5vA5+z8wdA2sOhgYi7sJgDs5zGe/6qkus10kT+Y1KjDuZNui WEe2Zaw7meDubkzZeiCPnQY0UEzypodFDHW+c2dJhTDTtOzaRnoDaWaZEhOXcOdjavt9 9QbmaVIvIere10k8olF8+Hc2nsUv+gMC4Dc4EZw2aNHIcUjKpzBdJ8Qent47IFsfRCMX ntZA== X-Gm-Message-State: AOAM532Zm1vsVP4DbdkX6Z6kWjKJu9ioYrWQlwOPGbC4Q7B/hZPyVGW8 N+mpmZ9s2pdIuP3baX8+/gjcoOo7UiY= X-Google-Smtp-Source: ABdhPJzkv3lS9kuzqOopAwA30eh7zEZHIyNIFHDRkrHhorbXzYaU6+d9O1ZGtc/7sg3l3ekovZTW3Q== X-Received: by 2002:a63:7a17:: with SMTP id v23mr15479039pgc.22.1632178411738; Mon, 20 Sep 2021 15:53:31 -0700 (PDT) Received: from localhost (c-73-25-156-94.hsd1.or.comcast.net. [73.25.156.94]) by smtp.gmail.com with ESMTPSA id y8sm16086983pfe.162.2021.09.20.15.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 15:53:30 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, Douglas Anderson , Laurent Pinchart , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 2/3] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid() Date: Mon, 20 Sep 2021 15:57:59 -0700 Message-Id: <20210920225801.227211-3-robdclark@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210920225801.227211-1-robdclark@gmail.com> References: <20210920225801.227211-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Rob Clark For the brave new world of bridges not creating their own connectors, we need to implement the max clock limitation via bridge->mode_valid() instead of connector->mode_valid(). v2: Drop unneeded connector->mode_valid() Signed-off-by: Rob Clark Reviewed-by: Douglas Anderson --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 41d48a393e7f..6154bed0af5b 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -615,20 +615,8 @@ static int ti_sn_bridge_connector_get_modes(struct drm_connector *connector) return drm_bridge_get_modes(pdata->next_bridge, connector); } -static enum drm_mode_status -ti_sn_bridge_connector_mode_valid(struct drm_connector *connector, - struct drm_display_mode *mode) -{ - /* maximum supported resolution is 4K at 60 fps */ - if (mode->clock > 594000) - return MODE_CLOCK_HIGH; - - return MODE_OK; -} - static struct drm_connector_helper_funcs ti_sn_bridge_connector_helper_funcs = { .get_modes = ti_sn_bridge_connector_get_modes, - .mode_valid = ti_sn_bridge_connector_mode_valid, }; static const struct drm_connector_funcs ti_sn_bridge_connector_funcs = { @@ -766,6 +754,18 @@ static void ti_sn_bridge_detach(struct drm_bridge *bridge) drm_dp_aux_unregister(&bridge_to_ti_sn65dsi86(bridge)->aux); } +static enum drm_mode_status +ti_sn_bridge_mode_valid(struct drm_bridge *bridge, + const struct drm_display_info *info, + const struct drm_display_mode *mode) +{ + /* maximum supported resolution is 4K at 60 fps */ + if (mode->clock > 594000) + return MODE_CLOCK_HIGH; + + return MODE_OK; +} + static void ti_sn_bridge_disable(struct drm_bridge *bridge) { struct ti_sn65dsi86 *pdata = bridge_to_ti_sn65dsi86(bridge); @@ -1127,6 +1127,7 @@ static void ti_sn_bridge_post_disable(struct drm_bridge *bridge) static const struct drm_bridge_funcs ti_sn_bridge_funcs = { .attach = ti_sn_bridge_attach, .detach = ti_sn_bridge_detach, + .mode_valid = ti_sn_bridge_mode_valid, .pre_enable = ti_sn_bridge_pre_enable, .enable = ti_sn_bridge_enable, .disable = ti_sn_bridge_disable, -- 2.31.1