From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C50E9C433F5 for ; Sat, 25 Sep 2021 00:05:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 770F561212 for ; Sat, 25 Sep 2021 00:05:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 770F561212 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC7406E2B8; Sat, 25 Sep 2021 00:05:08 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 861946E2B8 for ; Sat, 25 Sep 2021 00:05:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3C997610F7; Sat, 25 Sep 2021 00:05:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632528307; bh=PV0m8/mNhWOkqLynIUjRpnCW/bG3D80ZQ3VDxnH04pg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tOqzemfgl3T4JxRVmUTeZHMGI8pq8ThVAVZW9TBrKQ9da1lsg8invGwGVHLIqMHtT r6c7NfAOlCCS5KW1NBLDMDUCyR9MhWt+vThhpsfxYRRTXDW5Q2qdrrPj0ch0a4cW7U Hu9iUoqHiVLgAxgqH9FbXLxUXKm/7X+Aw/azF+B9aVSj1bqkEH4T+PlaHnOGYJT+dz c/TJYzHyvL8A0PNE+oowZdT370TB8toboVn3coHd4RxNSQh4mccD7Q2+4tHIeBXKWJ eFLyTbExAYaRJd11J+zmdlOWM6YwjSievIPgdhhjORrVY7r+f6F+IWENuieOOmRbON fKW6bEAgzjJkg== Date: Fri, 24 Sep 2021 17:05:05 -0700 From: Jakub Kicinski To: Justin Chen Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , "David S. Miller" , Rob Herring , Doug Berger , Andrew Lunn , Heiner Kallweit , Russell King , Sumit Semwal , Christian =?UTF-8?B?S8O2bmln?= , =?UTF-8?B?UmFmYcWCIE1p?= =?UTF-8?B?xYJlY2tp?= , Randy Dunlap , Arnd Bergmann , Michael Chan , Geert Uytterhoeven , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list), linux-media@vger.kernel.org (open list:DMA BUFFER SHARING FRAMEWORK), dri-devel@lists.freedesktop.org (open list:DMA BUFFER SHARING FRAMEWORK), linaro-mm-sig@lists.linaro.org (moderated list:DMA BUFFER SHARING FRAMEWORK) Subject: Re: [PATCH net-next 3/5] net: bcmasp: Add support for ASP2.0 Ethernet controller Message-ID: <20210924170505.6e62e32f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1632519891-26510-4-git-send-email-justinpopo6@gmail.com> References: <1632519891-26510-1-git-send-email-justinpopo6@gmail.com> <1632519891-26510-4-git-send-email-justinpopo6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 24 Sep 2021 14:44:49 -0700 Justin Chen wrote: > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced with 72165. This controller features two distinct Ethernet > ports that can be independently operated. > > This patch supports: > > - Wake-on-LAN using magic packets > - basic ethtool operations (link, counters, message level) > - MAC destination address filtering (promiscuous, ALL_MULTI, etc.) > > Signed-off-by: Justin Chen > Signed-off-by: Florian Fainelli Please clean up checkpatch --strict and make W=1 C=1 build of the new driver.