From: Ramalingam C <ramalingam.c@intel.com>
To: intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: [PATCH v9 4/9] drm/i915/gt: Pass the -EINVAL when emit_pte doesn't update any PTE
Date: Tue, 5 Apr 2022 20:38:35 +0530 [thread overview]
Message-ID: <20220405150840.29351-5-ramalingam.c@intel.com> (raw)
In-Reply-To: <20220405150840.29351-1-ramalingam.c@intel.com>
When emit_pte doesn't update any PTE with return value as 0, interpret
it as -EINVAL.
v2:
Add missing goto [Thomas]
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index e0f1c727662e..6378d4450e1a 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -577,7 +577,11 @@ intel_context_migrate_copy(struct intel_context *ce,
len = emit_pte(rq, &it_src, src_cache_level, src_is_lmem,
src_offset, CHUNK_SZ);
- if (len <= 0) {
+ if (!len) {
+ err = -EINVAL;
+ goto out_rq;
+ }
+ if (len < 0) {
err = len;
goto out_rq;
}
--
2.20.1
next prev parent reply other threads:[~2022-04-05 15:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 15:08 [PATCH v9 0/9] drm/i915/ttm: Evict and restore of compressed object Ramalingam C
2022-04-05 15:08 ` [PATCH v9 1/9] drm/i915/gt: use engine instance directly for offset Ramalingam C
2022-04-05 15:08 ` [PATCH v9 2/9] drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+ Ramalingam C
2022-04-05 15:08 ` [PATCH v9 3/9] drm/i915/gt: Optimize the migration and clear loop Ramalingam C
2022-04-05 15:08 ` Ramalingam C [this message]
2022-04-08 9:02 ` [Intel-gfx] [PATCH v9 4/9] drm/i915/gt: Pass the -EINVAL when emit_pte doesn't update any PTE Thomas Hellström (Intel)
2022-04-05 15:08 ` [PATCH v9 5/9] drm/i915/gt: Clear compress metadata for Flat-ccs objects Ramalingam C
2022-04-05 15:08 ` [PATCH v9 6/9] drm/i915/selftest_migrate: Consider the possible roundup of size Ramalingam C
2022-04-05 15:08 ` [PATCH v9 7/9] drm/i915/selftest_migrate: Check CCS meta data clear Ramalingam C
2022-04-05 15:08 ` [PATCH v9 8/9] drm/i915/gem: Add extra pages in ttm_tt for ccs data Ramalingam C
2022-04-05 15:08 ` [PATCH v9 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405150840.29351-5-ramalingam.c@intel.com \
--to=ramalingam.c@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).