From: Yunfei Dong <yunfei.dong@mediatek.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>,
Alexandre Courbot <acourbot@chromium.org>,
Nicolas Dufresne <nicolas@ndufresne.ca>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>
Cc: Irui Wang <irui.wang@mediatek.com>,
George Sun <george.sun@mediatek.com>,
Steve Cho <stevecho@chromium.org>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-kernel@vger.kernel.org,
dri-devel <dri-devel@lists.freedesktop.org>,
Xiaoyong Lu <xiaoyong.lu@mediatek.com>,
linux-mediatek@lists.infradead.org,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [PATCH v9, 11/17] media: mediatek: vcodec: Fix v4l2-compliance fail
Date: Fri, 8 Apr 2022 20:02:34 +0800 [thread overview]
Message-ID: <20220408120240.29571-12-yunfei.dong@mediatek.com> (raw)
In-Reply-To: <20220408120240.29571-1-yunfei.dong@mediatek.com>
Need to use default pic info when get pic info fail.
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Reviewed-by: Steve Cho <stevecho@chromium.org>
---
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
index dab6acb3158c..0d9007339faf 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
@@ -485,11 +485,14 @@ static int vidioc_vdec_s_fmt(struct file *file, void *priv,
ctx->picinfo.pic_w = pix_mp->width;
ctx->picinfo.pic_h = pix_mp->height;
+ /*
+ * If get pic info fail, need to use the default pic info params, or
+ * v4l2-compliance will fail
+ */
ret = vdec_if_get_param(ctx, GET_PARAM_PIC_INFO, &ctx->picinfo);
if (ret) {
mtk_v4l2_err("[%d]Error!! Get GET_PARAM_PICTURE_INFO Fail",
ctx->id);
- return -EINVAL;
}
ctx->last_decoded_picinfo = ctx->picinfo;
--
2.18.0
next prev parent reply other threads:[~2022-04-08 12:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 12:02 [PATCH v9, 00/15] media: mtk-vcodec: support for M8192 decoder Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 01/17] media: mediatek: vcodec: Add vdec enable/disable hardware helpers Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 02/17] media: mediatek: vcodec: Using firmware type to separate different firmware architecture Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 03/17] media: mediatek: vcodec: get capture queue buffer size from scp Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 04/17] media: mediatek: vcodec: Read max resolution from dec_capability Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 05/17] media: mediatek: vcodec: set each plane bytesused in buf prepare Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 06/17] media: mediatek: vcodec: Refactor get and put capture buffer flow Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 07/17] media: mediatek: vcodec: Refactor supported vdec formats and framesizes Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 08/17] media: mediatek: vcodec: Getting supported decoder format types Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 09/17] media: mediatek: vcodec: Add format to support MT21C Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 10/17] media: mediatek: vcodec: disable vp8 4K capability Yunfei Dong
2022-04-08 12:02 ` Yunfei Dong [this message]
2022-04-08 12:02 ` [PATCH v9, 12/17] media: mediatek: vcodec: record capture queue format type Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 13/17] media: mediatek: vcodec: Extract H264 common code Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 14/17] media: mediatek: vcodec: support stateless H.264 decoding for mt8192 Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 15/17] media: mediatek: vcodec: support stateless VP8 decoding Yunfei Dong
2022-04-08 12:02 ` [PATCH v9, 16/17] media: mediatek: vcodec: support stateless VP9 decoding Yunfei Dong
2022-04-08 19:07 ` kernel test robot
2022-04-09 5:32 ` kernel test robot
2022-04-09 13:19 ` kernel test robot
2022-04-08 12:02 ` [PATCH v9, 17/17] media: mediatek: vcodec: prevent kernel crash when rmmod mtk-vcodec-dec.ko Yunfei Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408120240.29571-12-yunfei.dong@mediatek.com \
--to=yunfei.dong@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frkoenig@chromium.org \
--cc=george.sun@mediatek.com \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=stevecho@chromium.org \
--cc=tfiga@google.com \
--cc=tiffany.lin@mediatek.com \
--cc=xiaoyong.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).