* [PATCH] drm/hisilicon/hibmc: add back depends on MMU
@ 2022-04-09 3:05 Randy Dunlap
0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2022-04-09 3:05 UTC (permalink / raw)
To: linux-kernel
Cc: kernel test robot, Xinliang Liu, Chen Feng, Randy Dunlap,
Javier Martinez Canillas, dri-devel, David Airlie, Xinwei Kong,
Thomas Zimmermann, Tian Tao
ARM64 always has CONFIG_MMU=y but adding a dependency on
COMPILE_TEST allows an arch with MMU optional (riscv in this case)
to build the hibmc driver, leading to a kconfig warning and
build errors, so restore the MMU dependency.
WARNING: unmet direct dependencies detected for DRM_TTM
Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && MMU [=n]
Selected by [y]:
- DRM_TTM_HELPER [=y] && HAS_IOMEM [=y] && DRM [=y]
- DRM_HISI_HIBMC [=y] && HAS_IOMEM [=y] && DRM [=y] && PCI [=y] && (ARM64 || COMPILE_TEST [=y])
riscv64-linux-ld: drivers/gpu/drm/ttm/ttm_bo_vm.o: in function `.L97':
ttm_bo_vm.c:(.text+0x814): undefined reference to `vmf_insert_pfn_prot'
riscv64-linux-ld: drivers/gpu/drm/ttm/ttm_bo_vm.o: in function `.L0 ':
ttm_bo_vm.c:(.text+0x9d0): undefined reference to `vmf_insert_pfn_prot'
Fixes: a0f25a6bb319 ("drm/hisilicon/hibmc: Allow to be built if COMPILE_TEST is enabled")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Xinliang Liu <xinliang.liu@linaro.org>
Cc: Tian Tao <tiantao6@hisilicon.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/gpu/drm/hisilicon/hibmc/Kconfig
+++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_HISI_HIBMC
tristate "DRM Support for Hisilicon Hibmc"
- depends on DRM && PCI && (ARM64 || COMPILE_TEST)
+ depends on DRM && PCI && MMU && (ARM64 || COMPILE_TEST)
select DRM_KMS_HELPER
select DRM_VRAM_HELPER
select DRM_TTM
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-04-09 3:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-09 3:05 [PATCH] drm/hisilicon/hibmc: add back depends on MMU Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).