From: Marek Vasut <marex@denx.de>
To: dri-devel@lists.freedesktop.org
Cc: "Marek Vasut" <marex@denx.de>,
"Christoph Niedermaier" <cniedermaier@dh-electronics.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
robert.foss@linaro.org, "Rob Herring" <robh+dt@kernel.org>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dmitry Osipenko" <digetx@gmail.com>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: [PATCH 2/2] drm/panel: lvds: Drop now redundant width-mm and height-mm check
Date: Mon, 11 Apr 2022 02:47:28 +0200 [thread overview]
Message-ID: <20220411004728.68203-2-marex@denx.de> (raw)
In-Reply-To: <20220411004728.68203-1-marex@denx.de>
The check for mandatory DT properties width-mm and height-mm is now
part of of_get_drm_panel_display_mode(), drop the redundant check
from this driver.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dmitry Osipenko <digetx@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
To: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/panel/panel-lvds.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index eca067e785796..f11252fb00fea 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -128,18 +128,6 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds)
return ret;
}
- if (lvds->dmode.width_mm == 0) {
- dev_err(lvds->dev, "%pOF: invalid or missing %s DT property\n",
- np, "width-mm");
- return -ENODEV;
- }
-
- if (lvds->dmode.height_mm == 0) {
- dev_err(lvds->dev, "%pOF: invalid or missing %s DT property\n",
- np, "height-mm");
- return -ENODEV;
- }
-
of_property_read_string(np, "label", &lvds->label);
ret = drm_of_lvds_get_data_mapping(np);
--
2.35.1
next prev parent reply other threads:[~2022-04-11 0:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 0:47 [PATCH 1/2] drm/modes: Make width-mm/height-mm check in of_get_drm_panel_display_mode() mandatory Marek Vasut
2022-04-11 0:47 ` Marek Vasut [this message]
2022-04-11 16:42 ` [PATCH 2/2] drm/panel: lvds: Drop now redundant width-mm and height-mm check Noralf Trønnes
2022-04-11 16:41 ` [PATCH 1/2] drm/modes: Make width-mm/height-mm check in of_get_drm_panel_display_mode() mandatory Noralf Trønnes
2022-04-21 21:15 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411004728.68203-2-marex@denx.de \
--to=marex@denx.de \
--cc=cniedermaier@dh-electronics.com \
--cc=daniel.vetter@ffwll.ch \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=noralf@tronnes.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).