From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: daniel@ffwll.ch, jason@jlekstrand.net, daniels@collabora.com,
skhawaja@google.com, maad.aldabagh@amd.com,
sergemetral@google.com, sumit.semwal@linaro.org,
gustavo@padovan.org, Felix.Kuehling@amd.com,
alexander.deucher@amd.com, tzimmermann@suse.de,
tvrtko.ursulin@linux.intel.com, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Cc: "Christian König" <christian.koenig@amd.com>
Subject: [PATCH 06/15] dma-buf: add user fence support to dma_fence_merge()
Date: Mon, 2 May 2022 18:37:13 +0200 [thread overview]
Message-ID: <20220502163722.3957-7-christian.koenig@amd.com> (raw)
In-Reply-To: <20220502163722.3957-1-christian.koenig@amd.com>
Just make sure that we forward the user fence status to the output
whenever any of the inputs are an user fence.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/dma-buf/dma-fence-unwrap.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/dma-buf/dma-fence-unwrap.c b/drivers/dma-buf/dma-fence-unwrap.c
index 87ee2efced10..dd3c43aba8f1 100644
--- a/drivers/dma-buf/dma-fence-unwrap.c
+++ b/drivers/dma-buf/dma-fence-unwrap.c
@@ -66,17 +66,19 @@ struct dma_fence *__dma_fence_merge(unsigned int num_fences,
{
struct dma_fence_array *result;
struct dma_fence *tmp, **array;
+ bool user_fence = false;
unsigned int i, count;
count = 0;
for (i = 0; i < num_fences; ++i) {
+ user_fence |= test_bit(DMA_FENCE_FLAG_USER, &fences[i]->flags);
dma_fence_unwrap_for_each(tmp, &iter[i], fences[i])
if (!dma_fence_is_signaled(tmp))
++count;
}
if (count == 0)
- return dma_fence_get_stub(false);
+ return dma_fence_get_stub(user_fence);
if (count > INT_MAX)
return NULL;
@@ -129,11 +131,12 @@ struct dma_fence *__dma_fence_merge(unsigned int num_fences,
} while (tmp);
if (count == 0) {
- tmp = dma_fence_get_stub(false);
+ tmp = dma_fence_get_stub(user_fence);
goto return_tmp;
}
- if (count == 1) {
+ if (count == 1 &&
+ test_bit(DMA_FENCE_FLAG_USER, &array[0]->flags) == user_fence) {
tmp = array[0];
goto return_tmp;
}
@@ -145,6 +148,8 @@ struct dma_fence *__dma_fence_merge(unsigned int num_fences,
tmp = NULL;
goto return_tmp;
}
+ if (user_fence)
+ set_bit(DMA_FENCE_FLAG_USER, &result->base.flags);
return &result->base;
return_tmp:
--
2.25.1
next prev parent reply other threads:[~2022-05-02 16:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 16:37 Tackling the indefinite/user DMA fence problem Christian König
2022-05-02 16:37 ` [PATCH 01/15] dma-buf: rename DMA_FENCE_FLAG_USER_BITS to _DEVICE Christian König
2022-05-02 16:37 ` [PATCH 02/15] dma-buf: introduce user fence support Christian König
2022-05-04 7:53 ` Tvrtko Ursulin
2022-05-04 9:15 ` Christian König
2022-05-02 16:37 ` [PATCH 03/15] dma-buf: add user fence support to dma_fence_array Christian König
2022-05-02 16:37 ` [PATCH 04/15] dma-buf: add user fence support to dma_fence_chain Christian König
2022-05-02 16:37 ` [PATCH 05/15] dma-buf: add user fence support to dma_resv Christian König
2022-05-02 16:37 ` Christian König [this message]
2022-05-02 16:37 ` [PATCH 07/15] dma-buf: add user fence utility functions Christian König
2022-05-02 16:37 ` [PATCH 08/15] dma-buf: add support for polling on user fences Christian König
2022-05-02 16:37 ` [PATCH 09/15] dma-buf/sync_file: add user fence support Christian König
2022-05-02 16:37 ` [PATCH 10/15] drm: add user fence support for atomic out fences Christian König
2022-05-02 16:37 ` [PATCH 11/15] drm: add user fence support for atomic in fences Christian König
2022-05-02 16:37 ` [PATCH 12/15] drm: add user fence support to drm_gem_plane_helper_prepare_fb Christian König
2022-05-02 16:37 ` [PATCH 13/15] drm: add user fence support to drm_syncobj Christian König
2022-05-02 16:37 ` [PATCH 14/15] drm/amdgpu: switch DM to atomic fence helpers Christian König
2022-05-02 16:37 ` [PATCH 15/15] drm/amdgpu: user fence proof of concept Christian König
2022-05-04 10:08 ` Tackling the indefinite/user DMA fence problem Daniel Vetter
2022-05-09 6:56 ` Christian König
2022-05-09 14:10 ` Daniel Vetter
2022-05-17 10:28 ` Christian König
2022-05-25 13:05 ` Daniel Vetter
2022-05-25 13:28 ` Michel Dänzer
2022-05-25 13:51 ` Daniel Vetter
2022-05-25 14:07 ` Simon Ser
2022-05-25 14:15 ` Daniel Stone
2022-05-25 14:22 ` Christian König
2022-05-25 14:25 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502163722.3957-7-christian.koenig@amd.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Felix.Kuehling@amd.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=jason@jlekstrand.net \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=maad.aldabagh@amd.com \
--cc=sergemetral@google.com \
--cc=skhawaja@google.com \
--cc=sumit.semwal@linaro.org \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).