From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9382DC433EF for ; Thu, 5 May 2022 22:20:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B8BB410E342; Thu, 5 May 2022 22:20:47 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4F8C10E342 for ; Thu, 5 May 2022 22:20:46 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id 795391F40EB1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651789245; bh=IqgWrsQ7M1kiyWJK+KEWncQxxmyl40O17cMv2BeJAZM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WINl7o4+WequxxSytUZt4txWZtOiVzMn8Oe/yw0ywq6gSVx8l6UxrDz3v0PpGlt6h UDitxFADuW19fZXUk/LzhWjSZwChusaokfIOVdXRSsgUprvXqPj9+sN1EJwgxueAdc OukGQCfmhJINyB7ZUJpneAtEaNF4dvpH2QC+lL3rXrSsUBosL08zBz6cPUdHd8p4xd cT2/UstKbK9OqDqqMn0QtVP/CaD8SkagtmZzuD+Mb1LTLangCsE9DGEfHyxdj/TD2+ 5x5tU/6u3gd7b7E/O12Lbkbb8xJmSvT4QwhrRHN8g7lusGir0xHHUoKh6HMYy/9lO4 kOrFUb8fajxWQ== Date: Thu, 5 May 2022 18:20:34 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Yunfei Dong Subject: Re: [PATCH v10, 16/17] media: mediatek: vcodec: support stateless VP9 decoding Message-ID: <20220505222034.fxw6y7wdf7wy3qi4@notapiano> References: <20220426100828.13429-1-yunfei.dong@mediatek.com> <20220426100828.13429-17-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220426100828.13429-17-yunfei.dong@mediatek.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew-CT Chen , Steve Cho , dri-devel , Xiaoyong Lu , Irui Wang , George Sun , Benjamin Gaignard , Nicolas Dufresne , Project_Global_Chrome_Upstream_Group@mediatek.com, Fritz Koenig , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Tiffany Lin , Tomasz Figa , Rob Herring , linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Matthias Brugger , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Alexandre Courbot , linux-kernel@vger.kernel.org, Hans Verkuil Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 26, 2022 at 06:08:27PM +0800, Yunfei Dong wrote: > Add support for VP9 decoding using the stateless API, > as supported by MT8192. And the drivers is lat and core architecture. > > Signed-off-by: Yunfei Dong > Signed-off-by: George Sun > Reviewed-by: AngeloGioacchino Del Regno > --- > .../media/platform/mediatek/vcodec/Makefile | 1 + > .../vcodec/mtk_vcodec_dec_stateless.c | 26 +- > .../platform/mediatek/vcodec/mtk_vcodec_drv.h | 1 + > .../vcodec/vdec/vdec_vp9_req_lat_if.c | 2031 +++++++++++++++++ > .../platform/mediatek/vcodec/vdec_drv_if.c | 4 + > .../platform/mediatek/vcodec/vdec_drv_if.h | 1 + > 6 files changed, 2061 insertions(+), 3 deletions(-) > create mode 100644 drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c > ... > + use_128 = !frame_is_intra && !vsi->frame.uh.last_frame_type; > + v4l2_vp9_adapt_coef_probs(pre_frame_ctx_helper, > + counts_helper, > + use_128, > + frame_is_intra); Hi Yunfei, I'm getting ERROR: modpost: "v4l2_vp9_adapt_noncoef_probs" [drivers/media/platform/mediatek/vcodec/mtk-vcodec-dec.ko] undefined! ERROR: modpost: "v4l2_vp9_adapt_coef_probs" [drivers/media/platform/mediatek/vcodec/mtk-vcodec-dec.ko] undefined! when building this series. Adding select V4L2_VP9 to config VIDEO_MEDIATEK_VCODEC solved the issue. Thanks, Nícolas