Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()

From: Maxime Ripard <maxime@cerno.tech>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: davidgow@google.com, airlied@linux.ie, dlatypov@google.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	tzimmermann@suse.de, "José Expósito" <jose.exposito89@gmail.com>,
	kunit-dev@googlegroups.com
Subject: Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()
Date: Mon, 6 Jun 2022 15:52:19 +0200	[thread overview]
Message-ID: <20220606135219.nwhp4fdawg2qjeam@houat> (raw)
In-Reply-To: <576ed6ef-b961-9214-2c9b-56cb5b493b4e@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]

hi,

On Mon, Jun 06, 2022 at 03:49:57PM +0200, Javier Martinez Canillas wrote:
> Hello Maxime,
> 
> On 6/6/22 15:42, Maxime Ripard wrote:
> > Hi,
> > 
> > On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote:
> >> Test the conversion from XRGB8888 to RGB332.
> >>
> >> What is tested?
> >>
> >>  - Different values for the X in XRGB8888 to make sure it is ignored
> >>  - Different clip values: Single pixel and full and partial buffer
> >>  - Well known colors: White, black, red, green, blue, magenta, yellow
> >>    and cyan
> >>  - Other colors: Randomly picked
> >>  - Destination pitch
> >>
> >> How to run the tests?
> >>
> >>  $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm \
> >>          --kconfig_add CONFIG_VIRTIO_UML=y \
> >>          --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y
> > 
> > It's not clear to me why you would need VIRTIO here? The Kunit config
> > file should be enough to run the tests properly
> >
> 
> It's needed or otherwise KUnit will complain with:
> 
> ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/.kunitconfig
> [15:47:31] Configuring KUnit Kernel ...
> Regenerating .config ...
> Populating config with:
> $ make ARCH=um O=.kunit olddefconfig
> ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config.
> This is probably due to unsatisfied dependencies.
> Missing: CONFIG_DRM=y, CONFIG_DRM_KUNIT_TEST=y
> Note: many Kconfig options aren't available on UML. You can try running on a different architecture with something like "--arch=x86_64".
> 
> The following works correctly but it won't use User Mode Linux:
> 
> ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/.kunitconfig --arch=x86_64

But then, can't we add them to .kunitconfig?

We should avoid that gotcha entirely

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]