From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09769C43334 for ; Tue, 5 Jul 2022 13:53:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 02B6A11B7B5; Tue, 5 Jul 2022 13:53:34 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id D7AE411AA35 for ; Tue, 5 Jul 2022 13:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657029211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uN5nWEVYHc9xedfrm0KeXe0ON9wRefPaICdww0TrCno=; b=AeGafMICjmED/i1zaNsSPzrGY65itn3bq4x+Cth9gD9jHUAWVfnMiZO3EKkoR0sIP91pMt sd7sQyVJsGkX3dutpCJMHsYEhDeKTfPD3hdYLpaVjTpXBFDoPaOGgOk7QHhuA/G0ZOuqLC E0VPGiO54Jk5KPniP4gRkWzaQg8QCTo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-665-j0eypEIsNi2bMMFTdSfFTw-1; Tue, 05 Jul 2022 09:53:26 -0400 X-MC-Unique: j0eypEIsNi2bMMFTdSfFTw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CD78580D41A; Tue, 5 Jul 2022 13:53:25 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6B6FB2166B26; Tue, 5 Jul 2022 13:53:25 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id EEDB81800083; Tue, 5 Jul 2022 15:53:23 +0200 (CEST) Date: Tue, 5 Jul 2022 15:53:23 +0200 From: Gerd Hoffmann To: Dmitry Osipenko Subject: Re: [PATCH v7 7/9] drm/virtio: Improve DMA API usage for shmem BOs Message-ID: <20220705135323.emr4gdbcxoisdcxe@sirius.home.kraxel.org> References: <20220630200726.1884320-1-dmitry.osipenko@collabora.com> <20220630200726.1884320-8-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220630200726.1884320-8-dmitry.osipenko@collabora.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@collabora.com, David Airlie , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Emil Velikov , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Gurchetan Singh , Thomas Zimmermann , Dmitry Osipenko , virtualization@lists.linux-foundation.org, Robin Murphy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, > - * So for the moment keep things as-is, with a bulky comment > - * for the next person who feels like removing this > - * drm_dev_set_unique() quirk. Dragons lurking here. It's not the first attempt to ditch this, and so far all have been rolled back due to regressions. Specifically Xorg is notoriously picky if it doesn't find its expectations fulfilled. Also note that pci is not the only virtio transport we have. What kind of testing has this patch seen? take care, Gerd