On 2022.07.13 09:11:55 +0100, Mauro Carvalho Chehab wrote: > Some functions seem to have been renamed without updating the kernel-doc > markup causing warnings. Also, struct intel_vgpu_dmabuf_obj is not > properly documented, but has a kerneld-doc markup. > > Fix those warnings: > drivers/gpu/drm/i915/gvt/aperture_gm.c:308: warning: expecting prototype for inte_gvt_free_vgpu_resource(). Prototype was for intel_vgpu_free_resource() instead > drivers/gpu/drm/i915/gvt/aperture_gm.c:344: warning: expecting prototype for intel_alloc_vgpu_resource(). Prototype was for intel_vgpu_alloc_resource() instead > drivers/gpu/drm/i915/gvt/cfg_space.c:257: warning: expecting prototype for intel_vgpu_emulate_cfg_read(). Prototype was for intel_vgpu_emulate_cfg_write() instead > drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'vgpu' not described in 'intel_vgpu_dmabuf_obj' > drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'info' not described in 'intel_vgpu_dmabuf_obj' > drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'dmabuf_id' not described in 'intel_vgpu_dmabuf_obj' > drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'kref' not described in 'intel_vgpu_dmabuf_obj' > drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'initref' not described in 'intel_vgpu_dmabuf_obj' > drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'list' not described in 'intel_vgpu_dmabuf_obj' > drivers/gpu/drm/i915/gvt/handlers.c:3066: warning: expecting prototype for intel_t_default_mmio_write(). Prototype was for intel_vgpu_default_mmio_write() instead > drivers/gpu/drm/i915/gvt/mmio_context.c:560: warning: expecting prototype for intel_gvt_switch_render_mmio(). Prototype was for intel_gvt_switch_mmio() instead > drivers/gpu/drm/i915/gvt/page_track.c:131: warning: expecting prototype for intel_vgpu_enable_page_track(). Prototype was for intel_vgpu_disable_page_track() instead > drivers/gpu/drm/i915/gvt/vgpu.c:215: warning: expecting prototype for intel_gvt_active_vgpu(). Prototype was for intel_gvt_activate_vgpu() instead > drivers/gpu/drm/i915/gvt/vgpu.c:230: warning: expecting prototype for intel_gvt_deactive_vgpu(). Prototype was for intel_gvt_deactivate_vgpu() instead > drivers/gpu/drm/i915/gvt/vgpu.c:358: warning: expecting prototype for intel_gvt_destroy_vgpu(). Prototype was for intel_gvt_destroy_idle_vgpu() instead > > Signed-off-by: Mauro Carvalho Chehab > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/ > > drivers/gpu/drm/i915/gvt/cfg_space.c | 2 +- > drivers/gpu/drm/i915/gvt/dmabuf.h | 2 +- > drivers/gpu/drm/i915/gvt/page_track.c | 2 +- > drivers/gpu/drm/i915/gvt/vgpu.c | 6 +++--- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gvt/cfg_space.c b/drivers/gpu/drm/i915/gvt/cfg_space.c > index dad3a6054335..a0fc6d356588 100644 > --- a/drivers/gpu/drm/i915/gvt/cfg_space.c > +++ b/drivers/gpu/drm/i915/gvt/cfg_space.c > @@ -243,7 +243,7 @@ static void emulate_pci_bar_write(struct intel_vgpu *vgpu, unsigned int offset, > } > > /** > - * intel_vgpu_emulate_cfg_read - emulate vGPU configuration space write > + * intel_vgpu_emulate_cfg_write - emulate vGPU configuration space write > * @vgpu: target vgpu > * @offset: offset > * @p_data: write data ptr > diff --git a/drivers/gpu/drm/i915/gvt/dmabuf.h b/drivers/gpu/drm/i915/gvt/dmabuf.h > index 5f8f03fb1d1b..3dcdb6570eda 100644 > --- a/drivers/gpu/drm/i915/gvt/dmabuf.h > +++ b/drivers/gpu/drm/i915/gvt/dmabuf.h > @@ -48,7 +48,7 @@ struct intel_vgpu_fb_info { > struct intel_vgpu_dmabuf_obj *obj; > }; > > -/** > +/* > * struct intel_vgpu_dmabuf_obj- Intel vGPU device buffer object > */ > struct intel_vgpu_dmabuf_obj { > diff --git a/drivers/gpu/drm/i915/gvt/page_track.c b/drivers/gpu/drm/i915/gvt/page_track.c > index 3375b51c75f1..df34e73cba41 100644 > --- a/drivers/gpu/drm/i915/gvt/page_track.c > +++ b/drivers/gpu/drm/i915/gvt/page_track.c > @@ -120,7 +120,7 @@ int intel_vgpu_enable_page_track(struct intel_vgpu *vgpu, unsigned long gfn) > } > > /** > - * intel_vgpu_enable_page_track - cancel write-protection on guest page > + * intel_vgpu_disable_page_track - cancel write-protection on guest page > * @vgpu: a vGPU > * @gfn: the gfn of guest page > * > diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c > index 46da19b3225d..8e71cda19995 100644 > --- a/drivers/gpu/drm/i915/gvt/vgpu.c > +++ b/drivers/gpu/drm/i915/gvt/vgpu.c > @@ -205,7 +205,7 @@ static void intel_gvt_update_vgpu_types(struct intel_gvt *gvt) > } > > /** > - * intel_gvt_active_vgpu - activate a virtual GPU > + * intel_gvt_activate_vgpu - activate a virtual GPU > * @vgpu: virtual GPU > * > * This function is called when user wants to activate a virtual GPU. > @@ -219,7 +219,7 @@ void intel_gvt_activate_vgpu(struct intel_vgpu *vgpu) > } > > /** > - * intel_gvt_deactive_vgpu - deactivate a virtual GPU > + * intel_gvt_deactivate_vgpu - deactivate a virtual GPU > * @vgpu: virtual GPU > * > * This function is called when user wants to deactivate a virtual GPU. > @@ -348,7 +348,7 @@ struct intel_vgpu *intel_gvt_create_idle_vgpu(struct intel_gvt *gvt) > } > > /** > - * intel_gvt_destroy_vgpu - destroy an idle virtual GPU > + * intel_gvt_destroy_idle_vgpu - destroy an idle virtual GPU > * @vgpu: virtual GPU > * > * This function is called when user wants to destroy an idle virtual GPU. > -- Acked-by: Zhenyu Wang Thanks! I'll put in queue with other gvt fixes.