From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <maxime@cerno.tech>
Cc: Dom Cobley <dom@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
dri-devel@lists.freedesktop.org,
Phil Elwell <phil@raspberrypi.com>
Subject: [PATCH v3 0/8] drm/vc4: Add generic helpers for HDMI scrambling
Date: Thu, 14 Jul 2022 11:12:44 +0200 [thread overview]
Message-ID: <20220714091252.2089015-1-maxime@cerno.tech> (raw)
Hi,
This is a follow-up of the work to support the interactions between the hotplug
and the scrambling support for vc4:
https://lore.kernel.org/dri-devel/20210507150515.257424-11-maxime@cerno.tech/
https://lore.kernel.org/dri-devel/20211025152903.1088803-10-maxime@cerno.tech/
https://lore.kernel.org/dri-devel/20211118103814.524670-1-maxime@cerno.tech/
Ville feedback was that the same discussion happened some time ago for i915,
and resulted in a function to do an full disable/enable cycle on reconnection
to avoid breaking the HDMI 2.0 spec.
While the previous versions of this series was moving the current scrambling
related functions into generic helpers to consolidate that logic, it proved to
be difficult to rework existing drivers to make use of it without hardware to
test it on and thus the code is (for now) private to vc4.
I still believe that long term, the code to decide if the scrambler needs to be
enabled or not should be moved into a generic helper.
This also means that we would need to move the format output decision to a
generic helper, which also makes sense to me but it probably going to be
controversial.
Let me know what you think,
Maxime
Changes from v2:
- Rebased on next-20220713
- Dropped the generic helpers and put them into vc4
Changes from v1:
- Dropped the 340MHz define
- Make drm_mode_hdmi_requires_scrambling use the bpc
- Make more drm_display_mode const in vc4
- Dropped the tegra conversion
- Added more comments
Maxime Ripard (8):
drm/vc4: hdmi: Constify drm_display_mode
drm/vc4: hdmi: Remove unused argument in vc4_hdmi_supports_scrambling
drm/vc4: hdmi: Remove mutex in detect
drm/vc4: hdmi: Simplify the hotplug handling
drm/vc4: hdmi: Switch to detect_ctx
drm/vc4: hdmi: Move vc4_hdmi_supports_scrambling() around
drm/vc4: hdmi: Reset link on hotplug
drm/scdc: Document hotplug gotchas
drivers/gpu/drm/display/drm_scdc_helper.c | 13 +
drivers/gpu/drm/vc4/vc4_hdmi.c | 309 ++++++++++++++--------
drivers/gpu/drm/vc4/vc4_hdmi.h | 12 +-
3 files changed, 220 insertions(+), 114 deletions(-)
--
2.36.1
next reply other threads:[~2022-07-14 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 9:12 Maxime Ripard [this message]
2022-07-14 9:12 ` [PATCH v3 1/8] drm/vc4: hdmi: Constify drm_display_mode Maxime Ripard
2022-07-14 9:12 ` [PATCH v3 2/8] drm/vc4: hdmi: Remove unused argument in vc4_hdmi_supports_scrambling Maxime Ripard
2022-07-14 9:12 ` [PATCH v3 3/8] drm/vc4: hdmi: Remove mutex in detect Maxime Ripard
2022-07-14 9:12 ` [PATCH v3 4/8] drm/vc4: hdmi: Simplify the hotplug handling Maxime Ripard
2022-07-14 9:12 ` [PATCH v3 5/8] drm/vc4: hdmi: Switch to detect_ctx Maxime Ripard
2022-07-14 9:12 ` [PATCH v3 6/8] drm/vc4: hdmi: Move vc4_hdmi_supports_scrambling() around Maxime Ripard
2022-07-14 9:12 ` [PATCH v3 7/8] drm/vc4: hdmi: Reset link on hotplug Maxime Ripard
2022-07-14 9:12 ` [PATCH v3 8/8] drm/scdc: Document hotplug gotchas Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714091252.2089015-1-maxime@cerno.tech \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=phil@raspberrypi.com \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).