From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6759DC43334 for ; Mon, 25 Jul 2022 23:59:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 82A5A10FB6F; Mon, 25 Jul 2022 23:59:08 +0000 (UTC) Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by gabe.freedesktop.org (Postfix) with ESMTPS id 54AA310FB6F; Mon, 25 Jul 2022 23:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=O2ubfH2wQgxmJZWUP8M1vkKi6rTyTW4C61EL27uDGLI=; b=FdDGoOYDIjVUe17qJdSxcppF/6 BgyYILkT7FztFKmP5+K0qCFLxZJWgrWhYxWMSilPQ4diZCLP3Se96eLLn4WPnI6lY6ITlMj6DAPQy VhK13AaOvQEp+JM6mzrrAjFHoNgvCfFnIecAQWxnBDbLf/CfOiQWjd7I/V6rMW2ANaWfyI1THxdfJ 2RRlR/Yi0CZ/dCebV1OhcjrSLd08zWg6GCAaPZSivHXCg/pYcRO1jjChs9qJFJNdIwNDcvmD+M9oP X/Ye4KdN1/p09or297EABop8W2NJ0cxKaB0HTzJ5EL18QHUWC8KRSokCcfX598Lc1yTlEhUU7Dwck hIqTgYGw==; Received: from [165.90.126.25] (helo=mail.igalia.com) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1oG7yX-006bNf-8M; Tue, 26 Jul 2022 01:59:01 +0200 Date: Mon, 25 Jul 2022 22:58:48 -0100 From: Melissa Wen To: Magali Lemes Subject: Re: [PATCH 2/2] drm/amd/display: include missing headers Message-ID: <20220725235848.372aapiwvmxiiowt@mail.igalia.com> References: <20220725181559.250030-1-magalilemes00@gmail.com> <20220725181559.250030-2-magalilemes00@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fydmeijpi4u4gmq5" Content-Disposition: inline In-Reply-To: <20220725181559.250030-2-magalilemes00@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: siqueirajordao@riseup.net, mairacanal@riseup.net, sunpeng.li@amd.com, tales.aparecida@gmail.com, Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, alexander.deucher@amd.com, isabbasso@riseup.net, andrealmeid@riseup.net, christian.koenig@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --fydmeijpi4u4gmq5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 07/25, Magali Lemes wrote: > Add missing headers to solve the following warnings from sparse: >=20 > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:656:17: wa= rning: symbol 'ddr4_wm_table_gs' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:693:17: wa= rning: symbol 'lpddr4_wm_table_gs' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:730:17: wa= rning: symbol 'lpddr4_wm_table_with_disabled_ppt' was not declared. Should = it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:767:17: wa= rning: symbol 'ddr4_wm_table_rn' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:804:17: wa= rning: symbol 'ddr4_1R_wm_table_rn' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/dcn20_fpu.c:841:17: wa= rning: symbol 'lpddr4_wm_table_rn' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.c:217:17: = warning: symbol 'ddr4_wm_table' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn301/dcn301_fpu.c:254:17: = warning: symbol 'lpddr5_wm_table' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/dcn31_fpu.c:53:30: war= ning: symbol 'dcn3_1_ip' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/dcn31_fpu.c:117:37: wa= rning: symbol 'dcn3_1_soc' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/dcn31_fpu.c:197:30: wa= rning: symbol 'dcn3_15_ip' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/dcn31_fpu.c:262:37: wa= rning: symbol 'dcn3_15_soc' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/dcn31_fpu.c:293:30: wa= rning: symbol 'dcn3_16_ip' was not declared. Should it be static? > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/dcn31_fpu.c:358:37: wa= rning: symbol 'dcn3_16_soc' was not declared. Should it be static? >=20 Hi Magali, Nice catch! See some comments below: > Signed-off-by: Magali Lemes > --- > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.h | 1 + > drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 1 + > drivers/gpu/drm/amd/display/dc/dml/dcn301/dcn301_fpu.c | 1 + > drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c | 3 +++ > 4 files changed, 6 insertions(+) >=20 > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.h b/= drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.h > index 2e088c5171b2..f1319957e400 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.h > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.h > @@ -28,6 +28,7 @@ > =20 > #include "clk_mgr.h" > #include "dm_pp_smu.h" > +#include "clk_mgr_internal.h" I see that this fix (right above) comes from another warning not listed in the commit message. Can you explicit it there or split it in another commit if possible? Also, clk_mgr/dcn21/rn_clk_mgr.c includes clk_mgr_internal.h and rn_clk_mgr.h; I wonder if a cleaner solution is to remove the `#include clk_mgr_internal.h` from rn_clk_mgr.c too. The remaining changes seems correct to me. Thanks, Melissa > =20 > extern struct wm_table ddr4_wm_table_gs; > extern struct wm_table lpddr4_wm_table_gs; > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c b/drive= rs/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c > index eeeae52fe6fc..45e9f4663abe 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c > +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c > @@ -30,6 +30,7 @@ > #include "dchubbub.h" > #include "dcn20/dcn20_resource.h" > #include "dcn21/dcn21_resource.h" > +#include "clk_mgr/dcn21/rn_clk_mgr.h" > =20 > #include "dcn20_fpu.h" > =20 > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn301/dcn301_fpu.c b/dri= vers/gpu/drm/amd/display/dc/dml/dcn301/dcn301_fpu.c > index 7ef66e511ec8..d211cf6d234c 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml/dcn301/dcn301_fpu.c > +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn301/dcn301_fpu.c > @@ -26,6 +26,7 @@ > #include "clk_mgr.h" > #include "dcn20/dcn20_resource.h" > #include "dcn301/dcn301_resource.h" > +#include "clk_mgr/dcn301/vg_clk_mgr.h" > =20 > #include "dml/dcn20/dcn20_fpu.h" > #include "dcn301_fpu.h" > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c b/drive= rs/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c > index e36cfa5985ea..2d11a2c13345 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c > +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c > @@ -25,6 +25,9 @@ > =20 > #include "resource.h" > #include "clk_mgr.h" > +#include "dcn31/dcn31_resource.h" > +#include "dcn315/dcn315_resource.h" > +#include "dcn316/dcn316_resource.h" > =20 > #include "dml/dcn20/dcn20_fpu.h" > #include "dcn31_fpu.h" > --=20 > 2.37.1 >=20 --fydmeijpi4u4gmq5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEd8WOo/JViG+Tu+XIwqF3j0dLehwFAmLfLhYACgkQwqF3j0dL ehxzPBAAlERN6pDxUTfpiujfTDPJOWpVtWnC1Masl4psyPTOojPrar7khCz7lyZL BVRSXjIGV7seRAe765s8oEb9D5GQUqMU3Jlpro1EBWF7AQ77qV3/hPlyhYCDr4tM am9En8V4PynUgos/ayu+ALEmgPNlBAlJd46fY2rln/4VlPAAyJosp1ipVMzMe4vL 6QPonpOvTVcVoc3LjNGc2sDGfu1Ktmmou6fRKiHAXk4Wfk8ak55yzH5AoWG+X881 SiiDdT+kt7U8c0cIdVvdt9T7aksOgPtAixDe22pZon2FaMfqjvOWrobRwOg2qAUG UXxHXxWUs1+2+y1J+AYx91WWdJ9A9S/po+Qaw/pdKNmGMwRQljcVTwrk4J46ib78 F71NSi+39+cvyNOmnZoYpCy0A+YXJWoLsXv6bw225ntqA7Jyqf3LstklMaJYeTgh m0gGwQ4eJXZqcnfY29S7W+O4jo6gQXJJBC6Di/bJO1MBUQmPgmFWjaKJdpt7Peax SHrzyQwz2GZr1g3hq8MM+9KezYp5BpcjJEdNyC22Tu4+5mEmvs8aR+ZlY4VEEfXE +UeILM57PyFFeYoqvL9wcyzPDCZwp+aHtl3Y7H7zxHZLcUmlpx9uAmipI3hobiKF k1a5jmi5Y3ez0FP14YsQPtyIE1EaEs+vSHbAXlPsn7tLIqpm16g= =MbwT -----END PGP SIGNATURE----- --fydmeijpi4u4gmq5--