From: Zhang Zekun <zhangzekun11@huawei.com>
To: <andrzej.hajda@intel.com>, <narmstrong@baylibre.com>,
<robert.foss@linaro.org>, <Laurent.pinchart@ideasonboard.com>,
<jonas@kwiboo.se>, <jernej.skrabec@gmail.com>, <airlied@linux.ie>,
<daniel@ffwll.ch>, <dianders@chromium.org>,
<briannorris@chromium.org>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>
Cc: xuqiang36@huawei.com
Subject: [PATCH -next] drm/bridge: Add missing clk_disable_unprepare() in analogix_dp_resume()
Date: Tue, 16 Aug 2022 06:42:31 +0000 [thread overview]
Message-ID: <20220816064231.60473-1-zhangzekun11@huawei.com> (raw)
Add the missing clk_disable_unprepare() before return from
analogix_dp_resume() in the error handling case.
Fixes: 211f276ed3d9 ("drm: bridge: analogix/dp: add panel prepare/unprepare in suspend/resume time")
Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 8aadcc0aa90b..a0fd652547f5 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1887,6 +1887,7 @@ int analogix_dp_resume(struct analogix_dp_device *dp)
if (dp->plat_data->panel) {
if (drm_panel_prepare(dp->plat_data->panel)) {
DRM_ERROR("failed to setup the panel\n");
+ clk_disable_unprepare(dp->clock);
return -EBUSY;
}
}
--
2.17.1
next reply other threads:[~2022-08-16 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 6:42 Zhang Zekun [this message]
2022-08-17 20:34 ` [PATCH -next] drm/bridge: Add missing clk_disable_unprepare() in analogix_dp_resume() Brian Norris
2022-08-18 0:05 ` Brian Norris
2022-08-23 1:15 ` Brian Norris
2022-08-17 20:53 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816064231.60473-1-zhangzekun11@huawei.com \
--to=zhangzekun11@huawei.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=briannorris@chromium.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=xuqiang36@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).