From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06FBBC25B08 for ; Wed, 17 Aug 2022 11:15:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC9D38B6AC; Wed, 17 Aug 2022 11:15:31 +0000 (UTC) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by gabe.freedesktop.org (Postfix) with ESMTPS id CFD2B113E6A for ; Wed, 17 Aug 2022 11:15:03 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 5E94E580DA3; Wed, 17 Aug 2022 07:15:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 17 Aug 2022 07:15:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660734900; x=1660742100; bh=7/MyY+LBb7 xbVEmhuCyBhoCzY/9cxkCFf1VHHVrX6CY=; b=grrDb7phnJ8YS7DoYmClhDowva mf0hyZG1cElbLmCByi9qZfwQST1mrUurzidSCbpXzLfvUzrbTrOQioCAKC7U2Fwp jm+jENEKf8Vy1T/MorGsNClgSxDglsVgGyCX7UfoFeVFnLOETgr0/p9hs3QB88dR sbSoRPnGd69728/P/mt+7Fh+vWebfjlS/I7UsqjhGtn17DbWdnP/EkpsYqbQNwVv WQtJ4vAXXBVssg+IMz+GS+lG3ddEwQCPDgiFnLFA9ysgfKqwRZXwt8UFyXWB1BS0 kUzrjtDuamQLJjwF4qqcj5aFreTij0nTlG0h1GIxKPYZ2AhmjLEmwgoC2u/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660734900; x=1660742100; bh=7/MyY+LBb7xbVEmhuCyBhoCzY/9c xkCFf1VHHVrX6CY=; b=1EjiYV1IDT9sKd5r3mLzkdKwMFMlonp4bEctBDecRUya ZlpnqtUdldGetHD37riEiUUvZGlMEqu124iAqLMJ5iN2ONf2abY5VWp06pRbQ+/6 6W4ZKgtun/ru5zgTMT/ePki4t9Z1FsEfCzHeI5zEz+PrbhaFCGLsggAXU5MVBu5U +FwyikIohL0SBGOuk1IfHbASHFnJCiOCRnZThfHbBprg6joaAp7F8MNh+k1pj/jf DyTXjPYwQFQehxwbJdfXESh1FquX9og/rEOuQMKCTlBFZrFevsqr6cgA4gaTkM4X WlmugzAHmc7tzr6NIUDl6X9UGByCvf/IOiJ6IMjRHQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehiedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeetfefffefgkedtfefgledugfdtjeefjedvtddtkeetieffjedvgfehheff hfevudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Aug 2022 07:14:57 -0400 (EDT) Date: Wed, 17 Aug 2022 13:14:54 +0200 From: Maxime Ripard To: Geert Uytterhoeven Subject: Re: [PATCH v1 05/35] drm/connector: Add TV standard property Message-ID: <20220817111454.pn2iltvyo2drebq7@houat> References: <20220728-rpi-analog-tv-properties-v1-5-3d53ae722097@cerno.tech> <20220816132040.uwirtjm5yr6rdd3q@houat> <20220816141116.5nuszmilqv2exdb3@houat> <20220816154956.pkdpxmmw27mia5ix@houat> <20220817074710.w4c4xwj7edly2b5p@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gu5whptxg6eujuan" Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , Neil Armstrong , David Airlie , DRI Development , Phil Elwell , Jerome Brunet , Samuel Holland , Kevin Hilman , Jernej Skrabec , Chen-Yu Tsai , linux-sunxi@lists.linux.dev, Martin Blumenstingl , "open list:ARM/Amlogic Meson..." , Linux ARM , Dom Cobley , Dave Stevenson , Linux Kernel Mailing List , Mateusz Kwiatkowski , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --gu5whptxg6eujuan Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 17, 2022 at 10:35:07AM +0200, Geert Uytterhoeven wrote: > Hi Maxime, >=20 > On Wed, Aug 17, 2022 at 9:47 AM Maxime Ripard wrote: > > On Wed, Aug 17, 2022 at 09:31:18AM +0200, Geert Uytterhoeven wrote: > > > On Tue, Aug 16, 2022 at 5:50 PM Maxime Ripard wro= te: > > > > On Tue, Aug 16, 2022 at 04:43:44PM +0200, Geert Uytterhoeven wrote: > > > > > > > > > Either you have to add them here (e.g. "hd720p50" and "hd= 720p60"), or > > > > > > > > > handle them through "@". The latter would impac= t "[PATCH v1 > > > > > > > > > 09/35] drm/modes: Move named modes parsing to a separate = function", as > > > > > > > > > currently a named mode and a refresh rate can't be specif= ied both. > > > > > > > > > > > > > > > > I think the former would make more sense. It simplifies a b= it the > > > > > > > > parser, and we're going to use a named mode anyway. > > > > > > > > > > > > > > > > > As "[PATCH v1 34/35] drm/modes: Introduce the tv_mode pro= perty as a > > > > > > > > > command-line option" uses a separate "tv_mode" option, an= d not the main > > > > > > > > > mode name, I think you want to add them here. > > > > > > > > > > > > > > > > It's a separate story I think, we could have a named mode h= d720p50, > > > > > > > > which would be equivalent to 1280x720,tv_mode=3Dhd720p > > > > > > > > > > > > > > So where's the field rate in "1280x720,tv_mode=3Dhd720p"? > > > > > > > > > > > > Yeah, sorry I meant 1280x720@50,tv_mode=3Dhd720p > > > > > > > > > > Above you said "I think the former would make more sense", so that > > > > > should be "1280x720,tv_mode=3Dhd720p50"? > > > > > > > > No, 720p at 50Hz would be either hd720p50 or 1280x720@50,tv_mode=3D= hd720p > > > > and 60Hz would be hd720p60 or 1280x720@60,tv_mode=3Dhd720p > > > > > > I disagree: hd720p50 and hd720p60 are different TV modes. > > > > I agree, and I don't see how that command-line doesn't express that? >=20 > Oh, I see what you mean: yes, it expresses that. > But it is inconsistent with the NTSC/PAL/SECAM/hd{480,576}[ip] modes, > where the TV mode specifies both number of lines and frame rate. Only if we're using a named mode, and naming is hard :) Honestly, I'd be inclined to drop the hd* for now from this series. I don't have a hardware to test it with, for some we don't even have drivers that could implement these modes, we don't have a spec to work =66rom, it looks like a recipe for failure :) Maxime --gu5whptxg6eujuan Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYvzNrgAKCRDj7w1vZxhR xZPiAP9cuj5zZR8NRJHbKfFO0mr9fc31dj4wR+Gpelf6U7ZzwQEAvGoAg1Oi6hb0 Hui+aaNLN6Rq3Vi1HR7q65YsP3trIwM= =i1o+ -----END PGP SIGNATURE----- --gu5whptxg6eujuan--