* [PATCH -next] video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci_init()
@ 2022-08-19 8:57 Yang Yingliang
2022-08-22 20:11 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-08-19 8:57 UTC (permalink / raw)
To: linux-kernel, dri-devel, linux-fbdev; +Cc: mpe, deller, christophe.leroy
Add missing pci_disable_device() in error path in chipsfb_pci_init().
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/video/fbdev/chipsfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
index 393894af26f8..2b00a9d554fc 100644
--- a/drivers/video/fbdev/chipsfb.c
+++ b/drivers/video/fbdev/chipsfb.c
@@ -430,6 +430,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
err_release_fb:
framebuffer_release(p);
err_disable:
+ pci_disable_device(dp);
err_out:
return rc;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci_init()
2022-08-19 8:57 [PATCH -next] video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci_init() Yang Yingliang
@ 2022-08-22 20:11 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2022-08-22 20:11 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, dri-devel, linux-fbdev
Cc: mpe, christophe.leroy
On 8/19/22 10:57, Yang Yingliang wrote:
> Add missing pci_disable_device() in error path in chipsfb_pci_init().
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/chipsfb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
> index 393894af26f8..2b00a9d554fc 100644
> --- a/drivers/video/fbdev/chipsfb.c
> +++ b/drivers/video/fbdev/chipsfb.c
> @@ -430,6 +430,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
> err_release_fb:
> framebuffer_release(p);
> err_disable:
> + pci_disable_device(dp);
> err_out:
> return rc;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-24 19:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-19 8:57 [PATCH -next] video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci_init() Yang Yingliang
2022-08-22 20:11 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).