Re: [Intel-gfx] [PATCH v2 09/15] drm/i915/pxp: add huc authentication and loading command

From: kernel test robot <lkp@intel.com>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
	Tomas Winkler <tomas.winkler@intel.com>,
	kbuild-all@lists.01.org, Vitaly Lubart <vitaly.lubart@intel.com>,
	Alan Previn <alan.previn.teres.alexis@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 09/15] drm/i915/pxp: add huc authentication and loading command
Date: Fri, 19 Aug 2022 12:11:08 +0800	[thread overview]
Message-ID: <202208191208.p5c4LVLR-lkp@intel.com> (raw)
In-Reply-To: <20220818230243.3921066-10-daniele.ceraolospurio@intel.com>

Hi Daniele,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniele-Ceraolo-Spurio/drm-i915-HuC-loading-for-DG2/20220819-070704
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-randconfig-s002 (https://download.01.org/0day-ci/archive/20220819/202208191208.p5c4LVLR-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/5a5d288c4c93865952809443a74032634bfb9921
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Daniele-Ceraolo-Spurio/drm-i915-HuC-loading-for-DG2/20220819-070704
        git checkout 5a5d288c4c93865952809443a74032634bfb9921
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/pxp/intel_pxp_huc.c:39:35: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le64 [assigned] [usertype] huc_base_address @@     got unsigned int [assigned] [usertype] huc_phys_addr @@
   drivers/gpu/drm/i915/pxp/intel_pxp_huc.c:39:35: sparse:     expected restricted __le64 [assigned] [usertype] huc_base_address
   drivers/gpu/drm/i915/pxp/intel_pxp_huc.c:39:35: sparse:     got unsigned int [assigned] [usertype] huc_phys_addr

vim +39 drivers/gpu/drm/i915/pxp/intel_pxp_huc.c

    17	
    18	int intel_pxp_huc_load_and_auth(struct intel_pxp *pxp)
    19	{
    20		struct intel_gt *gt = pxp_to_gt(pxp);
    21		struct intel_huc *huc = &gt->uc.huc;
    22		struct pxp_tee_start_huc_auth_in huc_in = {0};
    23		struct pxp_tee_start_huc_auth_out huc_out = {0};
    24		dma_addr_t huc_phys_addr;
    25		u8 client_id = 0;
    26		u8 fence_id = 0;
    27		int err;
    28	
    29		if (!pxp->pxp_component)
    30			return -ENODEV;
    31	
    32		huc_phys_addr = i915_gem_object_get_dma_address(huc->fw.obj, 0);
    33	
    34		/* write the PXP message into the lmem (the sg list) */
    35		huc_in.header.api_version = PXP_TEE_43_APIVER;
    36		huc_in.header.command_id  = PXP_TEE_43_START_HUC_AUTH;
    37		huc_in.header.status      = 0;
    38		huc_in.header.buffer_len  = sizeof(huc_in.huc_base_address);
  > 39		huc_in.huc_base_address   = huc_phys_addr;

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp