From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69C9CC04AA5 for ; Thu, 25 Aug 2022 02:22:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A3F214B394; Thu, 25 Aug 2022 02:21:57 +0000 (UTC) X-Greylist: delayed 392 seconds by postgrey-1.36 at gabe; Thu, 25 Aug 2022 02:21:42 UTC Received: from out0.migadu.com (out0.migadu.com [IPv6:2001:41d0:2:267::]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86B1792CAD for ; Thu, 25 Aug 2022 02:21:07 +0000 (UTC) Date: Thu, 25 Aug 2022 10:14:41 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1661393706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cpOx6dVV78jhXar+JPpWdb6xb0voKCMB3o04WKJhLiU=; b=tewPSVKgpBLdkLATs2Z1i+GU7HBTFWe6AwRsxt6en2hisViLYRkjth3UBtqR0ckiKKk1FP Ctq6a3PTjZcfLVPFGwj9wSYoIVUd1C010B8ZDEWkS46ENTqRbk/64rwvs3+Ny7vUzCNpSX s72KUYPFCQ2LuGdlxDucOuUiKagNhco= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Cai Huoqing To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: Remove the unused param "struct drm_buddy *mm" Message-ID: <20220825021441.GA8819@chq-T47> References: <20220627085405.221435-1-cai.huoqing@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220627085405.221435-1-cai.huoqing@linux.dev> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 27 6月 22 16:54:04, Cai Huoqing wrote: > Remove the param "struct drm_buddy *mm" which is unused in > the function drm_block_alloc()/drm_block_free(). Just ping this patch > > Signed-off-by: Cai Huoqing > --- > drivers/gpu/drm/drm_buddy.c | 25 +++++++++++-------------- > 1 file changed, 11 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c > index 11bb59399471..192c8b99fb43 100644 > --- a/drivers/gpu/drm/drm_buddy.c > +++ b/drivers/gpu/drm/drm_buddy.c > @@ -11,10 +11,8 @@ > > static struct kmem_cache *slab_blocks; > > -static struct drm_buddy_block *drm_block_alloc(struct drm_buddy *mm, > - struct drm_buddy_block *parent, > - unsigned int order, > - u64 offset) > +static struct drm_buddy_block * > +drm_block_alloc(struct drm_buddy_block *parent, unsigned int order, u64 offset) > { > struct drm_buddy_block *block; > > @@ -32,8 +30,7 @@ static struct drm_buddy_block *drm_block_alloc(struct drm_buddy *mm, > return block; > } > > -static void drm_block_free(struct drm_buddy *mm, > - struct drm_buddy_block *block) > +static void drm_block_free(struct drm_buddy_block *block) > { > kmem_cache_free(slab_blocks, block); > } > @@ -131,7 +128,7 @@ int drm_buddy_init(struct drm_buddy *mm, u64 size, u64 chunk_size) > root_size = rounddown_pow_of_two(size); > order = ilog2(root_size) - ilog2(chunk_size); > > - root = drm_block_alloc(mm, NULL, order, offset); > + root = drm_block_alloc(NULL, order, offset); > if (!root) > goto out_free_roots; > > @@ -151,7 +148,7 @@ int drm_buddy_init(struct drm_buddy *mm, u64 size, u64 chunk_size) > > out_free_roots: > while (i--) > - drm_block_free(mm, mm->roots[i]); > + drm_block_free(mm->roots[i]); > kfree(mm->roots); > out_free_list: > kfree(mm->free_list); > @@ -172,7 +169,7 @@ void drm_buddy_fini(struct drm_buddy *mm) > > for (i = 0; i < mm->n_roots; ++i) { > WARN_ON(!drm_buddy_block_is_free(mm->roots[i])); > - drm_block_free(mm, mm->roots[i]); > + drm_block_free(mm->roots[i]); > } > > WARN_ON(mm->avail != mm->size); > @@ -191,14 +188,14 @@ static int split_block(struct drm_buddy *mm, > BUG_ON(!drm_buddy_block_is_free(block)); > BUG_ON(!drm_buddy_block_order(block)); > > - block->left = drm_block_alloc(mm, block, block_order, offset); > + block->left = drm_block_alloc(block, block_order, offset); > if (!block->left) > return -ENOMEM; > > - block->right = drm_block_alloc(mm, block, block_order, > + block->right = drm_block_alloc(block, block_order, > offset + (mm->chunk_size << block_order)); > if (!block->right) { > - drm_block_free(mm, block->left); > + drm_block_free(block->left); > return -ENOMEM; > } > > @@ -257,8 +254,8 @@ static void __drm_buddy_free(struct drm_buddy *mm, > > list_del(&buddy->link); > > - drm_block_free(mm, block); > - drm_block_free(mm, buddy); > + drm_block_free(block); > + drm_block_free(buddy); > > block = parent; > } > -- > 2.25.1 >