From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Takanari Hayama <taki@igel.co.jp>,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
kieran.bingham+renesas@ideasonboard.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/3] media: vsp1: add premultiplied alpha support
Date: Tue, 6 Sep 2022 13:10:30 +0200 [thread overview]
Message-ID: <20220906131030.336aebcc@coco.lan> (raw)
In-Reply-To: <Yv73pNxr62j+hYd5@pendragon.ideasonboard.com>
Em Fri, 19 Aug 2022 05:38:28 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
> Mauro, would you be fine with this patch going through the DRM tree for
> v6.1 ? I don't foresee any risk of conflict with other changes to the
> VSP driver scheduled for the next kernel version. If that's fine with
> you, could you give an Acked-by ? Otherwise I can send you a pull
> request to create an immutable branch and base the rest on it in my pull
> request for DRM, but given how small this change is, it seems a bit
> overkill.
Please, don't top-post.
>
> On Fri, Aug 19, 2022 at 05:01:10AM +0300, Laurent Pinchart wrote:
> > Hi Hayama-san,
> >
> > Thank you for the patch.
> >
> > On Wed, Aug 10, 2022 at 05:37:09PM +0900, Takanari Hayama wrote:
> > > To support DRM blend mode in R-Car DU driver, we must be able to pass
> > > a plane with the premultiplied alpha. Adding a new property to
> > > vsp1_du_atomic_config allows the R-Car DU driver to pass the
> > > premultiplied alpha plane.
> > >
> > > Signed-off-by: Takanari Hayama <taki@igel.co.jp>
Sure, this can be merged via DRM tree.
> > > ---
> > > drivers/media/platform/renesas/vsp1/vsp1_drm.c | 2 ++
> > > include/media/vsp1.h | 2 ++
> > > 2 files changed, 4 insertions(+)
> > >
> > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drm.c b/drivers/media/platform/renesas/vsp1/vsp1_drm.c
> > > index 0c2507dc03d6..019e18976bd8 100644
> > > --- a/drivers/media/platform/renesas/vsp1/vsp1_drm.c
> > > +++ b/drivers/media/platform/renesas/vsp1/vsp1_drm.c
> > > @@ -856,6 +856,8 @@ int vsp1_du_atomic_update(struct device *dev, unsigned int pipe_index,
> > > rpf->mem.addr[1] = cfg->mem[1];
> > > rpf->mem.addr[2] = cfg->mem[2];
> > >
> > > + rpf->format.flags = (cfg->premult) ? V4L2_PIX_FMT_FLAG_PREMUL_ALPHA : 0;
> >
> > I'll drop the parentheses when applying.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
With this change:
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Regards,
Mauro
next prev parent reply other threads:[~2022-09-06 11:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 8:37 [PATCH v2 0/3] Add DRM pixel blend mode support to R-Car DU Takanari Hayama
2022-08-10 8:37 ` [PATCH v2 1/3] media: vsp1: add premultiplied alpha support Takanari Hayama
2022-08-10 17:41 ` Sergey Shtylyov
2022-08-16 6:01 ` Takanari Hayama
2022-08-19 2:01 ` Laurent Pinchart
2022-08-19 2:04 ` Takanari Hayama
2022-08-19 2:38 ` Laurent Pinchart
2022-09-06 11:10 ` Mauro Carvalho Chehab [this message]
2022-08-10 8:37 ` [PATCH v2 2/3] drm: rcar-du: Add DRM_MODE_BLEND_PREMULTI support Takanari Hayama
2022-08-19 2:08 ` Laurent Pinchart
2022-08-19 3:05 ` Takanari Hayama
2022-08-10 8:37 ` [PATCH v2 3/3] drm: rcar-du: Add DRM_MODE_BLEND_PIXEL_NONE support Takanari Hayama
2022-08-19 2:10 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906131030.336aebcc@coco.lan \
--to=mchehab@kernel.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=taki@igel.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).