dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	airlied@linux.ie, s.hauer@pengutronix.de,
	Chris Morgan <macromorgan@hotmail.com>,
	hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
	kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
	pgwipeout@gmail.com, linux-phy@lists.infradead.org,
	cl@rock-chips.com
Subject: [PATCH v2 0/5] rockchip-dsi for rk3568
Date: Tue,  6 Sep 2022 12:48:18 -0500	[thread overview]
Message-ID: <20220906174823.28561-1-macroalpha82@gmail.com> (raw)

From: Chris Morgan <macromorgan@hotmail.com>

This series adds support for the dsi and dphy controllers on the
Rockchip RK3568. I can confirm that for the Rockchip RK3568 this
current series DOES WORK now, but it requires rolling back clk changes
made for the HDMI driver. If the clock changes are not rolled back, the
image on the screen is shifted about 100 pixels to the right.

Clk changes in question:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/rockchip/clk-rk3568.c?id=ff3187eabb5ce478d15b6ed62eb286756adefac3
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/clk/rockchip/clk-rk3568.c?id=6e69052f01d9131388cfcfaee929120118a267f4

Tested on an Anbernic RG503 and RG353P with clock changes rolled back,
the hardware works correctly on both devices.

Changes since RFCv1:
 - Identified cause of image shift (clock changes).
 - Noted that driver works now.
 - Added devicetree nodes for rk356x.dtsi.

Chris Morgan (5):
  dt-bindings: display: rockchip-dsi: add rk3568 compatible
  dt-bindings: phy-rockchip-inno-dsidphy: add compatible for rk3568
  drm/rockchip: dsi: add rk3568 support
  phy/rockchip: inno-dsidphy: Add support for rk3568
  arm64: dts: rockchip: Add DSI and DSI-DPHY nodes to rk356x

 .../display/rockchip/dw_mipi_dsi_rockchip.txt |   1 +
 .../bindings/phy/rockchip,px30-dsi-dphy.yaml  |   1 +
 arch/arm64/boot/dts/rockchip/rk356x.dtsi      |  72 +++++++
 .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c   |  51 ++++-
 .../phy/rockchip/phy-rockchip-inno-dsidphy.c  | 204 ++++++++++++++----
 5 files changed, 281 insertions(+), 48 deletions(-)

-- 
2.25.1


             reply	other threads:[~2022-09-06 17:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06 17:48 Chris Morgan [this message]
2022-09-06 17:48 ` [PATCH v2 1/5] dt-bindings: display: rockchip-dsi: add rk3568 compatible Chris Morgan
2022-09-09  1:37   ` Rob Herring
2022-09-06 17:48 ` [PATCH v2 2/5] dt-bindings: phy-rockchip-inno-dsidphy: add compatible for rk3568 Chris Morgan
2022-09-09  1:38   ` Rob Herring
2022-09-09 13:56   ` Heiko Stübner
2022-09-06 17:48 ` [PATCH v2 3/5] drm/rockchip: dsi: add rk3568 support Chris Morgan
2022-09-06 17:48 ` [PATCH v2 4/5] phy/rockchip: inno-dsidphy: Add support for rk3568 Chris Morgan
2022-09-09 14:12   ` Heiko Stübner
2022-09-06 17:48 ` [PATCH v2 5/5] arm64: dts: rockchip: Add DSI and DSI-DPHY nodes to rk356x Chris Morgan
2022-09-06 17:57 ` [PATCH v2 0/5] rockchip-dsi for rk3568 Maya Matuszczyk
2022-09-06 21:38   ` Chris Morgan
2022-09-09 15:30 ` (subset) " Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220906174823.28561-1-macroalpha82@gmail.com \
    --to=macroalpha82@gmail.com \
    --cc=airlied@linux.ie \
    --cc=cl@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hjc@rock-chips.com \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=macromorgan@hotmail.com \
    --cc=pgwipeout@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).