dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>, dri-devel@lists.freedesktop.org
Subject: [PATCH v2 0/3] drm/gma500: Fix 2 locking related WARNs + IRQ handling
Date: Tue,  6 Sep 2022 22:38:49 +0200	[thread overview]
Message-ID: <20220906203852.527663-1-hdegoede@redhat.com> (raw)

Hi All,

I have been testing the gma500 code on a Packard Bell Dot SC (Intel Atom
N2600, cedarview) laptop because I'm working on aligning the gma500
backlight code with the changes done to other drivers in the recent
backlight refactoring.

During the testing I noticed dmesg filling with a WARN_ON constantly
triggering as well as gnome-shell hanging after a suspend-resume cycle.

This series fixes 2 locking WARNs as well as vblank IRQs no longer
getting processed after a suspend-resume.

Changes in v2:
- Drop "drm/gma500: Fix crtc_vblank reference leak when userspace queues multiple events"
- Add "drm/gma500: Fix (vblank) IRQs not working after suspend/resume"

Regards,

Hans


Hans de Goede (3):
  drm/gma500: Fix BUG: sleeping function called from invalid context
    errors
  drm/gma500: Fix WARN_ON(lock->magic != lock) error
  drm/gma500: Fix (vblank) IRQs not working after suspend/resume

 drivers/gpu/drm/gma500/cdv_device.c      |  4 +---
 drivers/gpu/drm/gma500/gem.c             |  4 ++--
 drivers/gpu/drm/gma500/gma_display.c     | 11 +++++++----
 drivers/gpu/drm/gma500/oaktrail_device.c |  5 +----
 drivers/gpu/drm/gma500/power.c           |  8 +-------
 drivers/gpu/drm/gma500/psb_drv.c         |  2 +-
 drivers/gpu/drm/gma500/psb_drv.h         |  5 +----
 drivers/gpu/drm/gma500/psb_irq.c         | 15 ++++++++++++---
 drivers/gpu/drm/gma500/psb_irq.h         |  2 +-
 9 files changed, 27 insertions(+), 29 deletions(-)

-- 
2.37.2


             reply	other threads:[~2022-09-06 20:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06 20:38 Hans de Goede [this message]
2022-09-06 20:38 ` [PATCH v2 1/3] drm/gma500: Fix BUG: sleeping function called from invalid context errors Hans de Goede
2022-09-06 20:38 ` [PATCH v2 2/3] drm/gma500: Fix WARN_ON(lock->magic != lock) error Hans de Goede
2022-09-09  8:20   ` Patrik Jakobsson
2022-09-09  9:03     ` Hans de Goede
2022-09-06 20:38 ` [PATCH v2 3/3] drm/gma500: Fix (vblank) IRQs not working after suspend/resume Hans de Goede
2022-09-08 13:26   ` Patrik Jakobsson
2022-09-08 13:39     ` Hans de Goede
2022-09-09  7:34       ` Patrik Jakobsson
2022-09-09  8:45         ` Hans de Goede
2022-09-10 19:50           ` Hans de Goede
2022-09-12 13:15             ` Patrik Jakobsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220906203852.527663-1-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=patrik.r.jakobsson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).