From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, airlied@redhat.com, sean@poorly.run, daniel@ffwll.ch
Cc: Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org
Subject: [PATCH v2 06/16] drm/udl: Remove udl_simple_display_pipe_mode_valid()
Date: Thu, 6 Oct 2022 11:53:45 +0200 [thread overview]
Message-ID: <20221006095355.23579-7-tzimmermann@suse.de> (raw)
In-Reply-To: <20221006095355.23579-1-tzimmermann@suse.de>
Remove the empty function udl_simple_display_pipe_mode_valid() and
let simple-KMS helpers accept the modes. No functional changes.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/gpu/drm/udl/udl_modeset.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
index 93e7554e83fa..7f8bde89396d 100644
--- a/drivers/gpu/drm/udl/udl_modeset.c
+++ b/drivers/gpu/drm/udl/udl_modeset.c
@@ -310,13 +310,6 @@ static const uint32_t udl_simple_display_pipe_formats[] = {
DRM_FORMAT_XRGB8888,
};
-static enum drm_mode_status
-udl_simple_display_pipe_mode_valid(struct drm_simple_display_pipe *pipe,
- const struct drm_display_mode *mode)
-{
- return MODE_OK;
-}
-
static void
udl_simple_display_pipe_enable(struct drm_simple_display_pipe *pipe,
struct drm_crtc_state *crtc_state,
@@ -398,7 +391,6 @@ udl_simple_display_pipe_update(struct drm_simple_display_pipe *pipe,
}
static const struct drm_simple_display_pipe_funcs udl_simple_display_pipe_funcs = {
- .mode_valid = udl_simple_display_pipe_mode_valid,
.enable = udl_simple_display_pipe_enable,
.disable = udl_simple_display_pipe_disable,
.update = udl_simple_display_pipe_update,
--
2.37.3
next prev parent reply other threads:[~2022-10-06 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 9:53 [PATCH v2 00/16] drm/udl: Better modesetting, hot-unplug, protocol Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 01/16] drm/udl: Rename struct udl_drm_connector to struct udl_connector Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 02/16] drm/udl: Test pixel limit in mode-config's mode-valid function Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 03/16] drm/udl: Use USB timeout constant when reading EDID Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 04/16] drm/udl: Various improvements to the connector Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 05/16] drm/udl: Move connector to modesetting code Thomas Zimmermann
2022-10-06 9:53 ` Thomas Zimmermann [this message]
2022-10-06 9:53 ` [PATCH v2 07/16] drm/udl: Convert to atomic-modesetting helpers Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 08/16] drm/udl: Simplify modesetting in CRTC's enable function Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 09/16] drm/udl: Support DRM hot-unplugging Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 10/16] drm/udl: Use damage iterator Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 11/16] drm/udl: Move register constants to udl_proto.h Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 12/16] drm/udl: Add constants for display-mode registers Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 13/16] drm/udl: Add register constants for color depth Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 14/16] drm/udl: Add register constants for video locks Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 15/16] drm/udl: Add register constants for framebuffer scanout addresses Thomas Zimmermann
2022-10-06 9:53 ` [PATCH v2 16/16] drm/udl: Add constants for commands Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006095355.23579-7-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).