From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org,
javierm@redhat.com, mripard@kernel.org,
maarten.lankhorst@linux.intel.com
Cc: linux-hyperv@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
xen-devel@lists.xenproject.org, linux-sunxi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
etnaviv@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
spice-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
freedreno@lists.freedesktop.org
Subject: [PATCH 08/21] drm/vboxvideo: Don't set struct drm_driver.lastclose
Date: Thu, 20 Oct 2022 12:37:42 +0200 [thread overview]
Message-ID: <20221020103755.24058-9-tzimmermann@suse.de> (raw)
In-Reply-To: <20221020103755.24058-1-tzimmermann@suse.de>
Don't set struct drm_driver.lastclose. It's used to restore the
fbdev console. But as vboxvideo uses generic fbdev emulation, the
console is being restored by the DRM client helpers already. See
the call to drm_client_dev_restore() in drm_lastclose().
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/vboxvideo/vbox_drv.c b/drivers/gpu/drm/vboxvideo/vbox_drv.c
index f4f2bd79a7cb6..1cd716eb17a1c 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_drv.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_drv.c
@@ -178,8 +178,6 @@ static const struct drm_driver driver = {
.driver_features =
DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
- .lastclose = drm_fb_helper_lastclose,
-
.fops = &vbox_fops,
.name = DRIVER_NAME,
.desc = DRIVER_DESC,
--
2.38.0
next prev parent reply other threads:[~2022-10-20 10:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 10:37 [PATCH 00/21] drm/fb-helper: Untangle fbdev emulation and helpers Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 01/21] drm/amdgpu: Don't set struct drm_driver.lastclose Thomas Zimmermann
2022-10-20 11:48 ` Christian König
2022-10-20 12:00 ` Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 02/21] drm/imx: " Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 03/21] drm/ingenic: " Thomas Zimmermann
2022-10-20 10:55 ` Sergey Shtylyov
2022-10-20 10:37 ` [PATCH 04/21] drm/komeda: " Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 05/21] drm/logicvc: " Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 06/21] drm/mcde: " Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 07/21] drm/rockchip: " Thomas Zimmermann
2022-10-20 10:37 ` Thomas Zimmermann [this message]
2022-10-20 10:37 ` [PATCH 09/21] drm/panel-ili9341: Include <linux/backlight.h> Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 10/21] drm/tve200: Include <linux/of.h> Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 11/21] drm/fb-helper: Cleanup include statements in header file Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 12/21] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 13/21] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 14/21] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() " Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 15/21] drm/fb-helper: Disconnect damage worker from update logic Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 16/21] drm/fb-helper: Call fb_sync in I/O functions Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 18/21] drm/fb_helper: Minimize damage-helper overhead Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 19/21] drm/fb-helper: Always initialize generic fbdev emulation Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 20/21] drm/fb-helper: Move generic fbdev emulation into separate source file Thomas Zimmermann
2022-10-20 10:37 ` [PATCH 21/21] drm/fb-helper: Remove unnecessary include statements Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020103755.24058-9-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=sam@ravnborg.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).