From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F6F8C4332F for ; Mon, 7 Nov 2022 13:25:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E2D7D10E310; Mon, 7 Nov 2022 13:25:14 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 73E4D10E30E for ; Mon, 7 Nov 2022 13:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667827510; x=1699363510; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hlL+DfWEWMRR8orTzyWzhpO4GGMnYRYRp0nALpNPto8=; b=cp6hbDSmSO83haL5ffl0FtbZ+43YDxoK4hJCJaS7Zd6yTeQNYibspmt9 Uv5Vm08/OSOohMKc0aDdTHfhNMsgd9oFZjZzLBvIy+qYk2/x3U5lvU1if o2ifI26yfcARX0xmC0d8pcS/1JN1PuZg0TVO//sTD50VEmgatRUr6pycG 4jHxaWtueyFH8o5UhwbOfyi9ykqdULvAEvcVBzXRIcaVSptVyO8nMEY5p pqwbWF+Asd7NXmIpk9WqQ4y6ePSNlJ0JOivmL6SeR8CuiYY1Xd42hyEwL bXPzOHNRPMUyDWwuiNf5j0SisV+L5lUjaI8iI73+Y0JkaydllpEnMn/Ql g==; X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="290129990" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="290129990" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 05:25:09 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="761093220" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="761093220" Received: from joe-255.igk.intel.com (HELO localhost) ([172.22.229.67]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 05:25:05 -0800 Date: Mon, 7 Nov 2022 14:25:03 +0100 From: Stanislaw Gruszka To: Jason Gunthorpe Subject: Re: [RFC PATCH v2 1/3] drivers/accel: define kconfig and register a new major Message-ID: <20221107132503.GA3590860@linux.intel.com> References: <20221102203405.1797491-1-ogabbay@kernel.org> <20221102203405.1797491-2-ogabbay@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoph Hellwig , Jiho Chu , Jeffrey Hugo , Arnd Bergmann , Tvrtko Ursulin , Kevin Hilman , Oded Gabbay , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maciej Kwapulinski , Jacek Lawrynowicz , Jagan Teki , Thomas Zimmermann , John Hubbard , Alex Deucher , Yuji Ishikawa , stanislaw.gruszka@intel.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi On Mon, Nov 07, 2022 at 09:10:36AM -0400, Jason Gunthorpe wrote: > On Mon, Nov 07, 2022 at 03:01:08PM +0200, Oded Gabbay wrote: > > I don't agree with your statement that it should be "a layer over top of DRM". > > Anything on top of DRM is a device driver. > > Accel is not a device driver, it is a new type of drm minor / drm driver. > > Yeah, I still think this is not the right way, you are getting almost > nothing from DRM and making everything more complicated in the > process. > > > The only alternative imo to that is to abandon the idea of reusing > > drm, and just make an independant accel core code. > > Not quite really, layer it properly and librarize parts of DRM into > things accel can re-use so they are not intimately tied to the DRM > struct device notion. What do you mean by "struct device notion" ? struct drm_devce ? Regards Stanislaw