From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A4D0C433FE for ; Tue, 8 Nov 2022 19:10:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C9D0510E4F9; Tue, 8 Nov 2022 19:10:21 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0FBC710E4F9 for ; Tue, 8 Nov 2022 19:10:17 +0000 (UTC) Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 820AC6600368; Tue, 8 Nov 2022 19:10:12 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667934616; bh=+x4MJ+AKsMXulMyAxgCPfV7Jwz5088uT1madjdL8Tz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BRDC25qS/b9DoOMeS9+X1xOhzrYzjJ0K+UMCDrdd5CzVCjVAppxTOHAWslva/SSu9 NL9nUjDGzLJZJpr+wMKKP9RIdrM7AaUWuJfEeWZRCIHN+eHEUsnb0EvACqTkv6W8Jp 4dntC6xlVsxRTOCRGoipLyVa4zRcMfGQzTqKM8Xn/11GTIkxDal0kLBGUkDnUBwt+t +opiUMga30d7GKHUBZAWoImtcmjGW1RVtmNOskstabT0EELCuWZ8LQoeA2XFkk7XEc teXnZwEdUPUZsMHtlNFFRq4f+Nf7dSENPvwVC6XuyIdlKeqZTtnXW2daF6ybhkdotC 41306fZsagfkQ== Date: Tue, 8 Nov 2022 14:10:08 -0500 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Matthias Brugger Subject: Re: [PATCH v28 04/11] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1 Message-ID: <20221108191008.lsasjskm7tzvpa42@notapiano> References: <20221107072243.15748-1-nancy.lin@mediatek.com> <20221107072243.15748-5-nancy.lin@mediatek.com> <90d8dfb1-2a37-e79a-b912-c77076e493c6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <90d8dfb1-2a37-e79a-b912-c77076e493c6@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, David Airlie , "jason-jh . lin" , dri-devel@lists.freedesktop.org, llvm@lists.linux.dev, Nick Desaulniers , linux-kernel@vger.kernel.org, Rob Herring , Yongqiang Niu , Nathan Chancellor , "Nancy.Lin" , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, wim@linux-watchdog.org, singo.chang@mediatek.com, linux@roeck-us.net, AngeloGioacchino Del Regno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Nov 08, 2022 at 06:46:54PM +0100, Matthias Brugger wrote: > On 07/11/2022 08:22, Nancy.Lin wrote: [..] > > --- a/drivers/soc/mediatek/mtk-mmsys.c > > +++ b/drivers/soc/mediatek/mtk-mmsys.c > > @@ -80,6 +80,12 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys0_driver_data = { > > .num_routes = ARRAY_SIZE(mmsys_mt8195_routing_table), > > }; > > +static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = { > > + .clk_driver = "clk-mt8195-vdo1", > > + .routes = mmsys_mt8195_vdo1_routing_table, > > + .num_routes = ARRAY_SIZE(mmsys_mt8195_vdo1_routing_table), > > +}; > > + > > static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data = { > > .clk_driver = "clk-mt8365-mm", > > .routes = mt8365_mmsys_routing_table, > > @@ -292,6 +298,10 @@ static const struct of_device_id of_match_mtk_mmsys[] = { > > .compatible = "mediatek,mt8195-vdosys0", > > .data = &mt8195_vdosys0_driver_data, > > It seems we are missing a patch in the series. vdosys0 also correct was > never introduced in the driver... Hi Matthias, as mentioned in the cover letter, this series is based on the series "Change mmsys compatible for mt8195 mediatek-drm" [1], which introduces vdosys0. This compatible entry specifically is added on patch 3 of that series [2]. [1] https://lore.kernel.org/all/20220927152704.12018-1-jason-jh.lin@mediatek.com/ [2] https://lore.kernel.org/all/20220927152704.12018-4-jason-jh.lin@mediatek.com/ Thanks, Nícolas > > > }, > > + { > > + .compatible = "mediatek,mt8195-vdosys1", > > + .data = &mt8195_vdosys1_driver_data, > > + }, > > { > > .compatible = "mediatek,mt8365-mmsys", > > .data = &mt8365_mmsys_driver_data,