From: "Maíra Canal" <mcanal@igalia.com>
To: "Maxime Ripard" <mripard@kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rob Clark" <robdclark@gmail.com>,
"Simon Ser" <contact@emersion.fr>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Zack Rusin" <zackr@vmware.com>
Cc: "André Almeida" <andrealmeid@igalia.com>,
intel-gfx@lists.freedesktop.org,
"Maíra Canal" <mcanal@igalia.com>,
dri-devel@lists.freedesktop.org, "Melissa Wen" <mwen@igalia.com>,
"VMware Graphics Reviewers"
<linux-graphics-maintainer@vmware.com>
Subject: [PATCH 2/5] drm/amdgpu: Remove redundant framebuffer format check
Date: Mon, 9 Jan 2023 07:58:05 -0300 [thread overview]
Message-ID: <20230109105807.18172-3-mcanal@igalia.com> (raw)
In-Reply-To: <20230109105807.18172-1-mcanal@igalia.com>
Now that framebuffer_check() verifies that the format is properly
supported, there is no need to check it again on amdgpu's inside
helpers.
Therefore, remove the redundant framebuffer format check from the
amdgpu_display_gem_fb_verify_and_init() function, letting
framebuffer_check() perform the framebuffer validation.
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index b22471b3bd63..611b7a4b086c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -1120,16 +1120,6 @@ static int amdgpu_display_gem_fb_verify_and_init(struct drm_device *dev,
rfb->base.obj[0] = obj;
drm_helper_mode_fill_fb_struct(dev, &rfb->base, mode_cmd);
- /* Verify that the modifier is supported. */
- if (!drm_any_plane_has_format(dev, mode_cmd->pixel_format,
- mode_cmd->modifier[0])) {
- drm_dbg_kms(dev,
- "unsupported pixel format %p4cc / modifier 0x%llx\n",
- &mode_cmd->pixel_format, mode_cmd->modifier[0]);
-
- ret = -EINVAL;
- goto err;
- }
ret = amdgpu_display_framebuffer_init(dev, rfb, mode_cmd, obj);
if (ret)
--
2.39.0
next prev parent reply other threads:[~2023-01-09 11:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 10:58 [PATCH 0/5] Check for valid framebuffer's format Maíra Canal
2023-01-09 10:58 ` [PATCH 1/5] drm/framebuffer: Check for valid formats Maíra Canal
2023-01-11 22:48 ` Daniel Vetter
2023-01-09 10:58 ` Maíra Canal [this message]
2023-01-12 12:17 ` [PATCH 2/5] drm/amdgpu: Remove redundant framebuffer format check Simon Ser
2023-01-09 10:58 ` [PATCH 3/5] drm/i915: " Maíra Canal
2023-01-12 12:18 ` Simon Ser
2023-01-12 12:43 ` Ville Syrjälä
2023-01-12 14:07 ` Maíra Canal
2023-01-12 15:15 ` Ville Syrjälä
2023-01-09 10:58 ` [PATCH 4/5] drm/vmwgfx: " Maíra Canal
2023-01-12 2:52 ` Zack Rusin
2023-01-09 10:58 ` [PATCH 5/5] drm/plane: Unexport drm_any_plane_has_format() Maíra Canal
2023-01-11 22:50 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109105807.18172-3-mcanal@igalia.com \
--to=mcanal@igalia.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=andrealmeid@igalia.com \
--cc=christian.koenig@amd.com \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-graphics-maintainer@vmware.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=robdclark@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).