From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46DADC38142 for ; Fri, 27 Jan 2023 08:13:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 34C3110E3EB; Fri, 27 Jan 2023 08:13:51 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id E464310E3EB for ; Fri, 27 Jan 2023 08:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674807228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wQyPt/6bZriSvjC5ZXh5l3TKz/N7A4kc1yntO2MilN0=; b=iP0ZxLbGyVGSfrhpV5PxEwmfmE2S6u/W0f+NKIkXh+vSqVLHDyUnTFCCqrkZDr1v9WrZTm jIRUcV60spwTHKhdb+ZrkhxiBaTRQdTTDCnDrwbDxsxjtWYziVknuHA24E7+IM6q+8vOAs SWXJlWDRh15i8+6UTP3Bre1eqfv/Z+k= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-252-Z6Nj1TXBPmq0ujnQ2BEItg-1; Fri, 27 Jan 2023 03:13:42 -0500 X-MC-Unique: Z6Nj1TXBPmq0ujnQ2BEItg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 39FAA3C0D845; Fri, 27 Jan 2023 08:13:41 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE9E5400DE84; Fri, 27 Jan 2023 08:13:40 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id B10301800606; Fri, 27 Jan 2023 09:13:39 +0100 (CET) Date: Fri, 27 Jan 2023 09:13:39 +0100 From: Gerd Hoffmann To: Dmitry Osipenko Subject: Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers Message-ID: <20230127081339.yovxofpboc4gfdgo@sirius.home.kraxel.org> References: <20230108210445.3948344-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Almeida , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kernel@collabora.com, Sumit Semwal , Steven Price , Gustavo Padovan , Alyssa Rosenzweig , Thomas Zimmermann , Abhinav Kumar , Gurchetan Singh , Sean Paul , Tomeu Vizoso , linux-kernel@vger.kernel.org, Qiang Yu , Dmitry Baryshkov , Christian =?utf-8?B?S8O2bmln?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 26, 2023 at 01:55:09AM +0300, Dmitry Osipenko wrote: > Hello Thomas and Gerd, > > On 1/9/23 00:04, Dmitry Osipenko wrote: > > This series: > > > > 1. Makes minor fixes for drm_gem_lru and Panfrost > > 2. Brings refactoring for older code > > 3. Adds common drm-shmem memory shrinker > > 4. Enables shrinker for VirtIO-GPU driver > > 5. Switches Panfrost driver to the common shrinker > > > > Changelog: > > > > v10:- Rebased on a recent linux-next. > > > > - Added Rob's ack to MSM "Prevent blocking within shrinker loop" patch. > > > > - Added Steven's ack/r-b/t-b for the Panfrost patches. > > > > - Fixed missing export of the new drm_gem_object_evict() function. > > > > - Added fixes tags to the first two patches that are making minor fixes, > > for consistency. > > Do you have comments on this version? Otherwise ack will be appreciated. > Thanks in advance! Don't feel like signing off on the locking changes, I'm not that familiar with the drm locking rules. So someone else looking at them would be good. Otherwise the series and specifically the virtio changes look good to me. Acked-by: Gerd Hoffmann take care, Gerd