From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB033C636D6 for ; Thu, 16 Feb 2023 10:39:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 553D510ED25; Thu, 16 Feb 2023 10:39:42 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A94E10ED1C for ; Thu, 16 Feb 2023 10:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676543973; x=1708079973; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VpDkwib9b5Jg2Zr5F6aRX7t0TwQZWlLJXwWMX8yOwKw=; b=Lzxj2w8R9QNhmr6ekzCOwcN66U3Xru4Nh2ZJ97gMxbiUWUZbou91SZpu xAVM5J0h+MYFgF5CinmHUTIKf6gCpCQBLgqkYUQLvRxWI7+9NrMFyrUPG RkjRnQETHU/MlnJCdOZGNbZh1TTvKmnXMCatpi/SwslFero48uCRB6hMF S0jWIOg+jMa0JX8ZIFuQ7f+YZI6RYFihbwa2PQdLYP7IT9KLi3Seik8kL eN5Eib95fMMQatwVtN1L8p4AUp+RwrMguyBAFJr7Mkevv3qukOKahRxzf LxMFTm3wk+RYIiJznmXpSZFZJ1Xm92k32gra2sc/5X3+Ku+agk/PyB5zx g==; X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="315362063" X-IronPort-AV: E=Sophos;i="5.97,302,1669104000"; d="scan'208";a="315362063" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2023 02:39:32 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="647632500" X-IronPort-AV: E=Sophos;i="5.97,302,1669104000"; d="scan'208";a="647632500" Received: from joe-255.igk.intel.com (HELO localhost) ([10.91.220.57]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2023 02:39:28 -0800 Date: Thu, 16 Feb 2023 11:39:26 +0100 From: Stanislaw Gruszka To: Oded Gabbay Subject: Re: [PATCH 18/27] habanalabs: change user interrupt to threaded IRQ Message-ID: <20230216103926.GB2849548@linux.intel.com> References: <20230212204454.2938561-1-ogabbay@kernel.org> <20230212204454.2938561-18-ogabbay@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230212204454.2938561-18-ogabbay@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tal Cohen , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Feb 12, 2023 at 10:44:45PM +0200, Oded Gabbay wrote: > - rc = request_irq(irq, irq_handler, 0, gaudi2_irq_name(i), &hdev->user_interrupt[j]); > + rc = request_threaded_irq(irq, irq_handler, hl_irq_user_interrupt_thread_handler, > + IRQF_ONESHOT, gaudi2_irq_name(i), &hdev->user_interrupt[j]); > + Would be nice to change to devm_ and simplify exit paths. Up to you. Regards Stanislaw