dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Melissa Wen <mwen@igalia.com>
To: "Maíra Canal" <mcanal@igalia.com>
Cc: dri-devel@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Javier Martinez Canillas <javierm@redhat.com>
Subject: Re: [PATCH] drm/vgem: Drop struct drm_vgem_gem_object
Date: Wed, 15 Mar 2023 21:31:27 -0100	[thread overview]
Message-ID: <20230315223127.5donvtt75hnabj2p@mail.igalia.com> (raw)
In-Reply-To: <20230222160617.171429-1-mcanal@igalia.com>

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]

On 02/22, Maíra Canal wrote:
> Commit 45d9c8dde4cd ("drm/vgem: use shmem helpers") introduced shmem
> helpers to vgem and with that, removed all uses of the struct
> drm_vgem_gem_object. So, as the struct is no longer used, delete it.
> 
Thanks,

Reviewed-by: Melissa Wen <mwen@igalia.com>

> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  drivers/gpu/drm/vgem/vgem_drv.h | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.h b/drivers/gpu/drm/vgem/vgem_drv.h
> index 0ed300317f87..34cf63e6fb3d 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.h
> +++ b/drivers/gpu/drm/vgem/vgem_drv.h
> @@ -39,17 +39,6 @@ struct vgem_file {
>  	struct mutex fence_mutex;
>  };
>  
> -#define to_vgem_bo(x) container_of(x, struct drm_vgem_gem_object, base)
> -struct drm_vgem_gem_object {
> -	struct drm_gem_object base;
> -
> -	struct page **pages;
> -	unsigned int pages_pin_count;
> -	struct mutex pages_lock;
> -
> -	struct sg_table *table;
> -};
> -
>  int vgem_fence_open(struct vgem_file *file);
>  int vgem_fence_attach_ioctl(struct drm_device *dev,
>  			    void *data,
> -- 
> 2.39.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-03-15 22:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-22 16:06 [PATCH] drm/vgem: Drop struct drm_vgem_gem_object Maíra Canal
2023-03-15 22:31 ` Melissa Wen [this message]
2023-03-20 19:07 ` Maíra Canal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230315223127.5donvtt75hnabj2p@mail.igalia.com \
    --to=mwen@igalia.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=mcanal@igalia.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).