From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 283DBC7618D for ; Mon, 20 Mar 2023 08:20:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1794F10E248; Mon, 20 Mar 2023 08:20:09 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 825A510E247; Mon, 20 Mar 2023 08:20:06 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 21A66CE109B; Mon, 20 Mar 2023 08:20:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 235EEC4339B; Mon, 20 Mar 2023 08:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679300397; bh=QpAVKqeubJthGIFfzcG7IrxW0rOZ+Vhr+iwkoRDofsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FFZN1EqsUQoijVrA3D5Fx3IRVmy5UZQwaNQowjxlcI1PUvmO+q1l3PCO0OrEwHHJ9 4y0X+YN50WzeAzMy5I6pO0s+0uzu8fDTns8Ub//f8u1eJT0NB+aGVr2AxT1uMw2+pH oQVR56yeDBULokyYbs7J9ZgvFmYQMcY7Z5RJkXFBM2v7B0Xh9XEYwRM3lTqvOnXARD Y6BG2OV6blc4Aj9wH7BgFQg1LPIdG5+lVQmiJ3F8WLjrrWWTNU9DUAa1KoMw17uzEn d76VrlM04pUdTq8OBGXKbELJ1IzMDYG2dBZlp9naz/A1WCvyCzBUF6bvIrFplI7w2T rg2BdxYDGt8zQ== Date: Mon, 20 Mar 2023 08:19:51 +0000 From: Lee Jones To: Alex Deucher Subject: Re: [PATCH 28/37] drm/amd/display/dc/core/dc_stat: Convert a couple of doc headers to kerneldoc format Message-ID: <20230320081951.GI9667@google.com> References: <20230317081718.2650744-1-lee@kernel.org> <20230317081718.2650744-29-lee@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , "Pan, Xinhui" , Rodrigo Siqueira , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= , amd-gfx@lists.freedesktop.org, Jasdeep Dhillon , Alex Deucher , Nicholas Kazlauskas , Mustapha Ghaddar Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 17 Mar 2023, Alex Deucher wrote: > On Fri, Mar 17, 2023 at 4:23 AM Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stat.c:38: warning: Cannot understand ***************************************************************************** > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stat.c:76: warning: Cannot understand ***************************************************************************** > > > > Cc: Harry Wentland > > Cc: Leo Li > > Cc: Rodrigo Siqueira > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: "Pan, Xinhui" > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Mustapha Ghaddar > > Cc: Nicholas Kazlauskas > > Cc: Jasdeep Dhillon > > Cc: amd-gfx@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Lee Jones > > --- > > drivers/gpu/drm/amd/display/dc/core/dc_stat.c | 28 +++++++------------ > > 1 file changed, 10 insertions(+), 18 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stat.c b/drivers/gpu/drm/amd/display/dc/core/dc_stat.c > > index 6c06587dd88c2..5f6392ae31a66 100644 > > --- a/drivers/gpu/drm/amd/display/dc/core/dc_stat.c > > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stat.c > > @@ -35,19 +35,15 @@ > > */ > > > > /** > > This looks like it follows some other documentation scheme. Would > probably be better to just remove the extra * and make it not kernel > doc. @Wentland, Harry @Siqueira, Rodrigo ? Happy to wait for further input. Either demoting from or converting to kerneldoc would be fine. > > - ***************************************************************************** > > - * Function: dc_stat_get_dmub_notification > > + * dc_stat_get_dmub_notification > > * > > - * @brief > > - * Calls dmub layer to retrieve dmub notification > > + * Calls dmub layer to retrieve dmub notification > > * > > - * @param > > - * [in] dc: dc structure > > - * [in] notify: dmub notification structure > > + * @dc: dc structure > > + * @notify: dmub notification structure > > * > > - * @return > > + * Returns > > * None > > - ***************************************************************************** > > */ > > void dc_stat_get_dmub_notification(const struct dc *dc, struct dmub_notification *notify) > > { > > @@ -73,19 +69,15 @@ void dc_stat_get_dmub_notification(const struct dc *dc, struct dmub_notification > > } > > > > /** > > - ***************************************************************************** > > - * Function: dc_stat_get_dmub_dataout > > + * dc_stat_get_dmub_dataout > > * > > - * @brief > > - * Calls dmub layer to retrieve dmub gpint dataout > > + * Calls dmub layer to retrieve dmub gpint dataout > > * > > - * @param > > - * [in] dc: dc structure > > - * [in] dataout: dmub gpint dataout > > + * @dc: dc structure > > + * @dataout: dmub gpint dataout > > * > > - * @return > > + * Returns > > * None > > - ***************************************************************************** > > */ > > void dc_stat_get_dmub_dataout(const struct dc *dc, uint32_t *dataout) > > { > > -- > > 2.40.0.rc1.284.g88254d51c5-goog > > -- Lee Jones [李琼斯]