From: Maxime Ripard <maxime@cerno.tech>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org,
Gerald Loacker <gerald.loacker@wolfvision.net>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 7/7] dt-bindings: display: add panel-timing property to sitronix,st7789v
Date: Wed, 29 Mar 2023 11:16:36 +0200 [thread overview]
Message-ID: <20230329091636.mu6ml3gvw5mvkhm4@penduick> (raw)
In-Reply-To: <dd26836f-d54c-65d1-0acc-8a09745bb066@wolfvision.net>
On Thu, Mar 16, 2023 at 11:29:53PM +0100, Michael Riesch wrote:
> Hi Rob,
>
> On 3/16/23 22:57, Rob Herring wrote:
> > On Tue, Mar 14, 2023 at 12:56:44PM +0100, Gerald Loacker wrote:
> >> The sitronix-st7789v driver now considers the panel-timing property.
> >
> > I read the patch for that and still don't know 'why'. Commit messages
> > should answer why.
> >
> >> Add the property to the documentation.
> >
> > We generally don't put timings in DT for panels. Why is this one
> > special?
>
> For now, having the timings in the device tree allows for setting the
> hsync/vsync/de polarity.
>
> As a next step, we aim to implement the partial mode feature of this
> panel. It is possible to use only a certain region of the panel, which
> is helpful e.g., when a part of the panel is occluded and should not be
> considered by DRM. We thought that this could be specified as timing in DT.
>
> (The hactive and vactive properties serve as dimensions of this certain
> region, of course. We still need to specify somehow the position of the
> region. Maybe with additional properties hactive-start and vactive-start?)
>
> What do you think about that?
I don't see why we would need the device tree to support that. What you
described is essentially what overscan is for HDMI/analog output, and we
already have everything to deal with overscan properly in KMS.
Maxime
next prev parent reply other threads:[~2023-03-29 9:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 11:56 [PATCH 0/7] Add timing override to sitronix,st7789v Gerald Loacker
2023-03-14 11:56 ` [PATCH 1/7] drm/panel: sitronix-st7789v: propagate RGB666 format Gerald Loacker
2023-03-14 11:56 ` [PATCH 2/7] drm/panel: sitronix-st7789v: add panel orientation support Gerald Loacker
2023-03-14 11:56 ` [PATCH 3/7] drm/panel: sitronix-st7789v: propagate h/v-sync polarity Gerald Loacker
2023-03-14 11:56 ` [PATCH 4/7] drm/panel: sitronix-st7789v: add bus_flags to connector Gerald Loacker
2023-03-14 11:56 ` [PATCH 5/7] drm/panel: sitronix-st7789v: parse device tree to override timing mode Gerald Loacker
2023-03-14 11:56 ` [PATCH 6/7] dt-bindings: display: add rotation property to sitronix, st7789v Gerald Loacker
2023-03-15 7:51 ` [PATCH 6/7] dt-bindings: display: add rotation property to sitronix,st7789v Krzysztof Kozlowski
2023-03-14 11:56 ` [PATCH 7/7] dt-bindings: display: add panel-timing property to sitronix, st7789v Gerald Loacker
2023-03-15 7:51 ` [PATCH 7/7] dt-bindings: display: add panel-timing property to sitronix,st7789v Krzysztof Kozlowski
2023-03-16 21:57 ` Rob Herring
2023-03-16 22:29 ` Michael Riesch
2023-03-29 9:16 ` Maxime Ripard [this message]
2023-03-29 10:08 ` Michael Riesch
2023-03-30 14:58 ` Maxime Ripard
2023-03-31 9:36 ` Michael Riesch
2023-04-04 16:04 ` Maxime Ripard
2023-04-04 16:26 ` Michael Riesch
2023-04-05 15:01 ` Maxime Ripard
2023-03-29 8:43 ` [PATCH 0/7] Add timing override " Gerald Loacker
2023-03-31 9:49 ` Michael Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329091636.mu6ml3gvw5mvkhm4@penduick \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gerald.loacker@wolfvision.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.riesch@wolfvision.net \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).