From: "Maíra Canal" <mcanal@igalia.com>
To: "David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rodrigo Siqueira" <rodrigosiqueiramelo@gmail.com>,
"Melissa Wen" <mwen@igalia.com>,
"Haneen Mohammed" <hamohammed.sa@gmail.com>,
"Igor Matheus Andrade Torrente" <igormtorrente@gmail.com>,
"Arthur Grillo" <arthurgrillo@riseup.net>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: "Maíra Canal" <mcanal@igalia.com>, dri-devel@lists.freedesktop.org
Subject: [PATCH v4 0/6] drm/vkms: introduce plane rotation property
Date: Tue, 18 Apr 2023 10:05:20 -0300 [thread overview]
Message-ID: <20230418130525.128733-1-mcanal@igalia.com> (raw)
This patchset implements all possible rotation value in vkms. All operations
were implemented by software by changing the way the pixels are read. The way
the blending is performed can be depicted as:
- rotate-0:
(x) ---->
----------------------
(y) | |
| | |
| | |
ˇ | |
----------------------
- rotate-90:
<---- (y)
----------------------
(x) | |
| | |
| | |
ˇ | |
----------------------
- rotate-180:
<---- (x)
----------------------
(y) | |
^ | |
| | |
| | |
----------------------
- rotate-270:
(y) ---->
----------------------
(x) | |
^ | |
| | |
| | |
----------------------
- reflect-x:
<---- (x)
----------------------
(y) | |
| | |
| | |
ˇ | |
----------------------
- reflect-y:
(x) ---->
----------------------
(y) | |
^ | |
| | |
| | |
----------------------
The patchset was tested with IGT's kms_rotation_crc tests and also with some
additional tests [1] for the reflection operations.
In order to avoid code duplication, I introduced a patch that isolates the
pixel format convertion and wraps it in a single loop.
I tried to apply Ville's suggestion to avoid hand rolled coordinate
calculation stuff. Although I couldn't apply all the code suggested by
Ville, I was able to remove all the hardcoded code related to the x-offset.
As VKMS' composition is performed by line, I still need to indicate the
right pixel, which means that I still have some hardcoded code. Thanks for
the suggestion, Ville! It really reduced the code complexity.
v1 -> v2: https://lore.kernel.org/dri-devel/20230406130138.70752-1-mcanal@igalia.com/T/
* Add patch to isolate pixel format conversion (Arthur Grillo).
v2 -> v3: https://lore.kernel.org/dri-devel/20230414135151.75975-1-mcanal@igalia.com/T/
* Use cpp to calculate pixel size instead of hard-coding (Arthur Grillo).
* Don't use the x coordinate in the pixel_read functions (Arthur Grillo).
* Use drm_rotate_simplify() to avoid hard-coding rotate-180 (Ville Syrjälä).
* Use u8* to input the src_pixels instead of using u16*.
v3 -> v4: https://lore.kernel.org/dri-devel/20230417121056.63917-1-mcanal@igalia.com/T/
* Create a original rectangle and a rotated rectangle and use the original
rectangle to offset the x-axis (Ville Syrjälä).
[1] https://patchwork.freedesktop.org/series/116025/
Best Regards,
- Maíra Canal
Maíra Canal (6):
drm/vkms: isolate pixel conversion functionality
drm/vkms: add rotate-0 and reflect-x property
drm/vkms: add reflect-y and rotate-180 property
drm/vkms: add rotate-90 property
drm/vkms: add rotate-270 property
drm/vkms: drop "Rotation" TODO
Documentation/gpu/vkms.rst | 2 +-
drivers/gpu/drm/vkms/vkms_composer.c | 38 ++++++--
drivers/gpu/drm/vkms/vkms_drv.h | 6 +-
drivers/gpu/drm/vkms/vkms_formats.c | 139 +++++++++++++--------------
drivers/gpu/drm/vkms/vkms_formats.h | 2 +-
drivers/gpu/drm/vkms/vkms_plane.c | 16 ++-
6 files changed, 117 insertions(+), 86 deletions(-)
--
2.39.2
next reply other threads:[~2023-04-18 13:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 13:05 Maíra Canal [this message]
2023-04-18 13:05 ` [PATCH v4 1/6] drm/vkms: isolate pixel conversion functionality Maíra Canal
2023-04-24 21:22 ` Maíra Canal
2023-04-18 13:05 ` [PATCH v4 2/6] drm/vkms: add rotate-0 and reflect-x property Maíra Canal
2023-04-18 13:05 ` [PATCH v4 3/6] drm/vkms: add reflect-y and rotate-180 property Maíra Canal
2023-04-18 13:05 ` [PATCH v4 4/6] drm/vkms: add rotate-90 property Maíra Canal
2023-05-07 20:48 ` Melissa Wen
2023-04-18 13:05 ` [PATCH v4 5/6] drm/vkms: add rotate-270 property Maíra Canal
2023-04-18 13:05 ` [PATCH v4 6/6] drm/vkms: drop "Rotation" TODO Maíra Canal
2023-05-07 20:54 ` [PATCH v4 0/6] drm/vkms: introduce plane rotation property Melissa Wen
2023-05-08 13:02 ` Maíra Canal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418130525.128733-1-mcanal@igalia.com \
--to=mcanal@igalia.com \
--cc=airlied@gmail.com \
--cc=arthurgrillo@riseup.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=igormtorrente@gmail.com \
--cc=mwen@igalia.com \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).