Re: (subset) [PATCH 00/19] drm/bridge: Convert to platform remove callback returning void - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Neil Armstrong <neil.armstrong@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	dri-devel@lists.freedesktop.org,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Sam Ravnborg <sam@ravnborg.org>, Rahul T R <r-ravikumar@ti.com>,
	Robert Foss <rfoss@kernel.org>, kernel test robot <lkp@intel.com>,
	Jayshri Pawar <jpawar@cadence.com>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Minghao Chi <chi.minghao@zte.com.cn>,
	Liu Ying <victor.liu@nxp.com>, NXP Linux Team <linux-imx@nxp.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jani Nikula <jani.nikula@intel.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Mark Brown <broonie@kernel.org>,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Sandor Yu <Sandor.yu@nxp.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: (subset) [PATCH 00/19] drm/bridge: Convert to platform remove callback returning void
Date: Tue, 9 May 2023 08:07:25 +0200	[thread overview]
Message-ID: <20230509060725.fywaewxmgobe4fph@pengutronix.de> (raw)
In-Reply-To: <167930965268.2514063.17744962269901362155.b4-ty@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1833 bytes --]

Hello Neil,

On Mon, Mar 20, 2023 at 11:54:12AM +0100, Neil Armstrong wrote:
> On Sat, 18 Mar 2023 20:07:45 +0100, Uwe Kleine-König wrote:
> > this series adapts the platform drivers below drivers/gpu/drm/bridge to use the
> > .remove_new() callback. Compared to the traditional .remove() callback
> > .remove_new() returns no value. This is a good thing because the driver core
> > doesn't (and cannot) cope for errors during remove. The only effect of a
> > non-zero return value in .remove() is that the driver core emits a warning. The
> > device is removed anyhow and an early return from .remove() usually yields a
> > resource leak.
> > 
> > [...]
> 
> Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
> 
> [02/19] drm/bridge: cdns-dsi: Convert to platform remove callback returning void
>         https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d5701d8f5210f8c70ffd1b51283b2373573e7b5a
> [04/19] drm/bridge: display-connector: Convert to platform remove callback returning void
>         https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d1837136d184dda0585a687c614a9117cc87ad27
> [05/19] drm/bridge: fsl-ldb: Convert to platform remove callback returning void
>         https://cgit.freedesktop.org/drm/drm-misc/commit/?id=be5c6b177229c5cb40f3fef785250afbfd669175
> [...]

I wonder what made you skip patches #1 and #3. I got some feedback by
Laurent for patch #1. In the end it was Laurent's "I don't have a string
preference here." vs me thinking that the patch is good as is. Was that
the reason to skip it? Patch #3 depends on patch #1.

Would it help to resent?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]