From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Tony Lindgren <tony@atomide.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Helge Deller <deller@gmx.de>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Andreas Kemnade <andreas@kemnade.info>,
linux-input@vger.kernel.org,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-mmc@vger.kernel.org, linux-mips@vger.kernel.org,
linux-spi@vger.kernel.org, Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes
Date: Wed, 17 May 2023 22:59:11 +0300 [thread overview]
Message-ID: <20230517195911.GG271152@darkstar.musicnaut.iki.fi> (raw)
In-Reply-To: <20230430-nokia770-regression-v4-1-9b6dc5536b17@linaro.org>
Hi,
This does not compile as nokia770_ads7846_props is declared twice,
and nokia770_cbus_props and nokia770_mpuio_gpiochip_swnode are missing.
On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote:
> +static const struct software_node_ref_args nokia770_cbus_gpio_refs[] = {
> + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 9, 0),
> + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 10, 0),
> + SOFTWARE_NODE_REFERENCE(&nokia770_mpuio_gpiochip_swnode, 11, 0),
> +};
These should be nokia770_mpuio_gpiochip_node.
> +static const struct property_entry nokia770_ads7846_props[] = {
> + PROPERTY_ENTRY_REF_ARRAY("gpios", nokia770_cbus_gpio_refs),
> + { }
> };
This should be nokia770_cbus_props.
A.
next prev parent reply other threads:[~2023-05-17 20:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 21:20 [PATCH v4 0/4] Fix up Nokia 770 regression Linus Walleij
2023-05-08 21:20 ` [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes Linus Walleij
2023-05-08 21:24 ` Dmitry Torokhov
2023-05-17 19:59 ` Aaro Koskinen [this message]
2023-05-17 21:11 ` Linus Walleij
2023-05-17 20:39 ` Aaro Koskinen
2023-05-17 21:20 ` Linus Walleij
2023-06-04 15:44 ` Christophe JAILLET
2023-06-06 19:15 ` Linus Walleij
2023-06-05 18:33 ` Guenter Roeck
2023-05-08 21:20 ` [PATCH v4 2/4] ARM/mmc: Convert old mmci-omap to GPIO descriptors Linus Walleij
2023-05-17 20:30 ` Aaro Koskinen
2023-05-17 21:36 ` Linus Walleij
2023-06-14 8:44 ` Peter Vasil
2023-06-14 9:24 ` Linus Walleij
2023-05-08 21:20 ` [PATCH v4 3/4] ARM: omap1: Fix up the Nokia 770 board device IRQs Linus Walleij
2023-05-08 21:20 ` [PATCH v4 4/4] ARM: dts: Fix erroneous ADS touchscreen polarities Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517195911.GG271152@darkstar.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=bartosz.golaszewski@linaro.org \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=deller@gmx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=haojian.zhuang@gmail.com \
--cc=jmkrzyszt@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=tony@atomide.com \
--cc=tsbogend@alpha.franken.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).