dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: devicetree@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Maxime Ripard <mripard@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH 1/7] drm/panel: sitronix-st7789v: Prevent core spi warnings
Date: Sat, 10 Jun 2023 22:06:58 +0200	[thread overview]
Message-ID: <20230610200658.GB1041001@ravnborg.org> (raw)
In-Reply-To: <20230609145951.853533-2-miquel.raynal@bootlin.com>

On Fri, Jun 09, 2023 at 04:59:45PM +0200, Miquel Raynal wrote:
> The spi core warns us about using an of_device_id table without a
> spi_device_id table aside for module utilities in orter to not rely on
> OF modaliases. Just add this table using the device name without the
> vendor prefix (as it is usually done).
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> index bbc4569cbcdc..c67b9adb157f 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> @@ -400,9 +400,16 @@ static const struct of_device_id st7789v_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, st7789v_of_match);
>  
> +static const struct spi_device_id st7789v_ids[] = {
> +	{ "st7789v", },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(spi, st7789v_ids);
> +
>  static struct spi_driver st7789v_driver = {
>  	.probe = st7789v_probe,
>  	.remove = st7789v_remove,
> +	.id_table = st7789v_ids,
>  	.driver = {
>  		.name = "st7789v",
>  		.of_match_table = st7789v_of_match,
> -- 
> 2.34.1

  reply	other threads:[~2023-06-10 20:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 14:59 [PATCH 0/7] drm/panel: sitronix-st7789v: Support ET028013DMA panel Miquel Raynal
2023-06-09 14:59 ` [PATCH 1/7] drm/panel: sitronix-st7789v: Prevent core spi warnings Miquel Raynal
2023-06-10 20:06   ` Sam Ravnborg [this message]
2023-06-13  6:15   ` Michael Riesch
2023-06-13  6:56     ` Miquel Raynal
2023-06-14 23:22       ` Sebastian Reichel
2023-06-15  5:43         ` Sam Ravnborg
2023-06-15 12:58           ` Sebastian Reichel
2023-06-09 14:59 ` [PATCH 2/7] drm/panel: sitronix-st7789v: Use 9 bits per spi word by default Miquel Raynal
2023-06-10 20:09   ` Sam Ravnborg
2023-06-09 14:59 ` [PATCH 3/7] drm/panel: sitronix-st7789v: Specify the expected bus format Miquel Raynal
2023-06-10 20:12   ` Sam Ravnborg
2023-06-16  9:56     ` Miquel Raynal
2023-06-12  8:44   ` Maxime Ripard
2023-06-09 14:59 ` [PATCH 4/7] drm/panel: sitronix-st7789v: Use platform data Miquel Raynal
2023-06-10 20:15   ` Sam Ravnborg
2023-06-09 14:59 ` [PATCH 5/7] dt-bindings: display: st7789v: Add the edt, et028013dma panel compatible Miquel Raynal
2023-06-09 14:59 ` [PATCH 6/7] drm/panel: sitronix-st7789v: Add EDT ET028013DMA panel support Miquel Raynal
2023-06-10 20:22   ` Sam Ravnborg
2023-06-12  8:51   ` Maxime Ripard
2023-06-16 10:01     ` Miquel Raynal
2023-06-09 14:59 ` [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID Miquel Raynal
2023-06-10 20:45   ` Sam Ravnborg
2023-06-14 23:27     ` Sebastian Reichel
2023-06-16 10:13       ` Miquel Raynal
2023-06-16 13:38         ` Sebastian Reichel
2023-06-13  6:25   ` Michael Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230610200658.GB1041001@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk+dt@kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).