From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: "Victoria Brekenfeld" <victoria@system76.com>,
"DRI Development" <dri-devel@lists.freedesktop.org>,
mdaenzer@redhat.com, aleixpol@kde.org, Rodrigo.Siqueira@amd.com,
amd-gfx@lists.freedesktop.org,
wayland-devel <wayland-devel@lists.freedesktop.org>,
"Jonas Ådahl" <jadahl@redhat.com>,
"Uma Shankar" <uma.shankar@intel.com>,
tzimmermann@suse.de, sunpeng.li@amd.com,
"Sebastian Wick" <sebastian.wick@redhat.com>,
mripard@kernel.org, "Melissa Wen" <mwen@igalia.com>,
"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
"Pekka Paalanen" <pekka.paalanen@collabora.com>,
Xinhui.Pan@amd.com, xaver.hugl@gmail.com,
linux-renesas-soc@vger.kernel.org, alexander.deucher@amd.com,
christian.koenig@amd.com, "Joshua Ashton" <joshua@froggi.es>
Subject: [RFC 0/9] drm: rcar-du: cmm: Enable 3D LUT support
Date: Wed, 21 Jun 2023 10:10:22 +0200 [thread overview]
Message-ID: <20230621081031.7876-1-jacopo.mondi@ideasonboard.com> (raw)
Hello, this series is based on the RFC sent by Melssa Wen:
"[RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface"
https://lore.kernel.org/dri-devel/20230109143846.1966301-1-mwen@igalia.com/
that introduces CRTC properties to control 3D LUT operations.
The R-Car DU peripheral has a post-blending color management pipeline (CMM)
composed by (in order of processing) a 3D LUT a 1D LUT and a Color conversion
unit.
The CMM driver already supported operating the 1D LUT, this series add support
for the cubic LUT (named CLU).
I've been made aware by Melissa and Pekka that the focus of upstream for
color management properties is now on the definition of the "Plane color
pipeline" properties
https://lore.kernel.org/dri-devel/QMers3awXvNCQlyhWdTtsPwkp5ie9bze_hD5nAccFW7a_RXlWjYB7MoUW_8CKLT2bSQwIXVi5H6VULYIxCdgvryZoAoJnC5lZgyK1QWn488=@emersion.fr/
Unfortunately the model there proposed doesn't match the R-Car DU hardware which
has color management at the post-blending level and not per plane (I've cc-ed
all the receivers of that series, just in case).
The user-space interface has been validated with dedicated unit tests for
the R-Car DU test suite (kms-test) which are available at:
https://git.sr.ht/~jmondi_/kms-test
The series validates the usage of the HW interface in the hope of re-starting
discussions and interests in the definition of CRTC color management
properties.
Thanks
j
Alex Hung (1):
drm: Add 3D LUT mode and its attributes
Jacopo Mondi (1):
drm: rcar-du: crtc: Enable 3D LUT
Kieran Bingham (2):
drm: rcar-du: cmm: Provide 3D-CLU support
drm: rcar-du: kms: Configure the CLU
Laurent Pinchart (1):
drm: rcar-du: cmm: Refactor LUT configuration
Melissa Wen (4):
drm/drm_color_mgmt: add shaper LUT to color mgmt properties
drm/drm_color_mgmt: add 3D LUT props to DRM color mgmt
drm/drm_color_mgmt: add function to create 3D LUT modes supported
drm/drm_color_mgmt: add function to attach 3D LUT props
drivers/gpu/drm/drm_atomic_state_helper.c | 7 ++
drivers/gpu/drm/drm_atomic_uapi.c | 24 ++++
drivers/gpu/drm/drm_color_mgmt.c | 113 +++++++++++++++++++
drivers/gpu/drm/drm_fb_helper.c | 5 +
drivers/gpu/drm/drm_mode_config.c | 21 ++++
drivers/gpu/drm/rcar-du/rcar_cmm.c | 127 ++++++++++++++++------
drivers/gpu/drm/rcar-du/rcar_cmm.h | 36 +++++-
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 68 +++++++++---
include/drm/drm_color_mgmt.h | 7 ++
include/drm/drm_crtc.h | 32 +++++-
include/drm/drm_mode_config.h | 25 +++++
include/drm/drm_mode_object.h | 2 +-
include/uapi/drm/drm_mode.h | 17 +++
13 files changed, 428 insertions(+), 56 deletions(-)
--
2.40.1
next reply other threads:[~2023-06-21 8:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 8:10 Jacopo Mondi [this message]
2023-06-21 8:10 ` [RFC 1/9] drm: Add 3D LUT mode and its attributes Jacopo Mondi
2023-06-21 8:10 ` [RFC 2/9] drm/drm_color_mgmt: add shaper LUT to color mgmt properties Jacopo Mondi
2023-06-21 8:10 ` [RFC 3/9] drm/drm_color_mgmt: add 3D LUT props to DRM color mgmt Jacopo Mondi
2023-06-21 8:10 ` [RFC 4/9] drm/drm_color_mgmt: add function to create 3D LUT modes supported Jacopo Mondi
2023-06-21 8:10 ` [RFC 5/9] drm/drm_color_mgmt: add function to attach 3D LUT props Jacopo Mondi
2023-06-21 8:10 ` [RFC 6/9] drm: rcar-du: cmm: Refactor LUT configuration Jacopo Mondi
2023-06-21 8:10 ` [RFC 7/9] drm: rcar-du: cmm: Provide 3D-CLU support Jacopo Mondi
2023-06-21 8:10 ` [RFC 8/9] drm: rcar-du: kms: Configure the CLU Jacopo Mondi
2023-06-21 8:10 ` [RFC 9/9] drm: rcar-du: crtc: Enable 3D LUT Jacopo Mondi
2023-06-21 10:33 ` [RFC 0/9] drm: rcar-du: cmm: Enable 3D LUT support Pekka Paalanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621081031.7876-1-jacopo.mondi@ideasonboard.com \
--to=jacopo.mondi@ideasonboard.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=aleixpol@kde.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jadahl@redhat.com \
--cc=joshua@froggi.es \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mdaenzer@redhat.com \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=pekka.paalanen@collabora.com \
--cc=sebastian.wick@redhat.com \
--cc=sunpeng.li@amd.com \
--cc=tzimmermann@suse.de \
--cc=uma.shankar@intel.com \
--cc=victoria@system76.com \
--cc=wayland-devel@lists.freedesktop.org \
--cc=xaver.hugl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).