From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99468C25B49 for ; Mon, 23 Oct 2023 17:34:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C769810E219; Mon, 23 Oct 2023 17:34:02 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 457F410E219 for ; Mon, 23 Oct 2023 17:34:01 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 73153CE24D1; Mon, 23 Oct 2023 17:33:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53682C433C8; Mon, 23 Oct 2023 17:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698082435; bh=4d7J4UL5e0se16HtXrPNAXciTYKxyup73uY3njGx/tc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rZZYcrZyJe7SIkIBEcxXv8DLargOmDFor0R5Wg1c8Zs2qP2sif0SJRN+HZHm034L4 Lr1pKF0ELhpLw7AnligOfRSqM5x2uvu6g5tagdVErPVluMvtzB8Z8uJKpejBs4c9eo t1uuS14rnGCayd0d1QqemTvTCNbLAMYp6sP2gn0RDWyiFXfO0ZlbvFGT6sQSTTUg3T OjtjVGY24jdMkqjjDSsAys0wWMBfEG5+yekGSe1hhjzBq3mShOfM842L+GdUdanOjN T9zczlElvAuF6/1AoTxzki1nTwWvAazefXVPPop4ZSQR5Ly8aGPlBGzM9Jc27SPr7y 0BGfwgRhc1vRw== Date: Mon, 23 Oct 2023 18:33:49 +0100 From: Conor Dooley To: Alexandre Mergnat Subject: Re: [PATCH 02/18] dt-bindings: display: mediatek: ccorr: add binding for MT8365 SoC Message-ID: <20231023-marrow-modified-fdeff0fea45a@spud> References: <20231023-display-support-v1-0-5c860ed5c33b@baylibre.com> <20231023-display-support-v1-2-5c860ed5c33b@baylibre.com> <20231023-reshoot-liquefy-429aacb68694@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="thOqX6IfbyWP13q3" Content-Disposition: inline In-Reply-To: <20231023-reshoot-liquefy-429aacb68694@spud> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Catalin Marinas , dri-devel@lists.freedesktop.org, Thierry Reding , Krzysztof Kozlowski , Will Deacon , linux-pwm@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Chun-Kuang Hu , Conor Dooley , Jitao Shi , Xinlei Lee , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --thOqX6IfbyWP13q3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 23, 2023 at 06:31:45PM +0100, Conor Dooley wrote: > On Mon, Oct 23, 2023 at 04:40:02PM +0200, Alexandre Mergnat wrote: > > Display Color Correction for MT8365 is compatible with another SoC. > > Then, add MT8365 binding along with MT8183 SoC. >=20 > This commit message's first line is too vague & the second doesn't make > sense. I suspect something as succinct as "Document the display colour > correction on mt, which is compatible with that of the mt" > does what you are looking for. >=20 > I suspect this is going to apply to the rest of the series... It does, as does the comment about s/binding/compatible/ I left on patch 1. >=20 > Cheers, > Conor. >=20 >=20 > >=20 > > Signed-off-by: Alexandre Mergnat > > --- > > Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml= | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediate= k,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,= ccorr.yaml > > index 8c2a737237f2..9f8366763831 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr= =2Eyaml > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr= =2Eyaml > > @@ -24,6 +24,9 @@ properties: > > - enum: > > - mediatek,mt8183-disp-ccorr > > - mediatek,mt8192-disp-ccorr > > + - items: > > + - const: mediatek,mt8365-disp-ccorr > > + - const: mediatek,mt8183-disp-ccorr > > - items: > > - enum: > > - mediatek,mt8186-disp-ccorr > >=20 > > --=20 > > 2.25.1 > >=20 --thOqX6IfbyWP13q3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZTaufAAKCRB4tDGHoIJi 0kKzAQDMUo1M62BZW0+LDaZBbv8k7iM/aEWPjra25PQw/lkNHAD+Krqai8nG55h2 m2Gi2YrEijqBX7inn96eMRSpD+rIfA8= =RW59 -----END PGP SIGNATURE----- --thOqX6IfbyWP13q3--